> We should have an explicit test configuration where we run code that we ship. This looks similar to various extra assertions we run in DEBUG builds (for example bug 1363886), so that would be ideal IMO, but I could also live with `warnings-as-errors` being _off_ in debug builds if folks want the default test behavior to be with it on. Oh, I also remember us wanting to run return value assertions from bug 1363886 in _local_ builds (somehow), even if not debug, because that's where they make most sense, while implementing an API. `warnings-as-errors` seems like a similar thing we would want in local builds, and also in debug builds on Try as a safety check.
Bug 1723189 Comment 1 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
> We should have an explicit test configuration where we run code that we ship. This looks similar to various extra assertions we run in DEBUG builds (for example bug 1363886), so that would be ideal IMO, but I could also live with `warnings-as-errors` being _off_ in debug builds if folks want the default test behavior to be with it on. Oh, I also remember us wanting to run return value assertions from bug 1363886 in _local_ builds (somehow), even if it's an opt build, because that's where they make most sense, while implementing an API. `warnings-as-errors` seems like a similar thing we would want in local builds, and also in debug builds on Try as a safety check.