Hmm, are we sure that `WillDestroyCurrentMessageLoop` ever does what we expect it to do? The message we print is only conditional with an `#ifdef' and the existence of the `process_` handle, but I see it appearing in the logs I looked at only when we actually block. We call `WillDestroyCurrentMessageLoop` only [if we had a `DestructionObserver` registered](https://searchfox.org/mozilla-central/rev/fb8d77331582639ea6848a61dd8ee812fac31b77/ipc/chromium/src/base/message_loop.cc#269-270). So my doubt would be that the normal flow unregisters that observer before we get into `MessageLoop::~MessageLoop` and that if we get here with a registered observer we always block?
Bug 1730374 Comment 57 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Hmm, are we sure that `WillDestroyCurrentMessageLoop` ever does what we expect it to do? The message we print is only conditional with an `#ifdef` and the existence of the `process_` handle, but I see it appearing in the logs I looked at only when we actually block. We call `WillDestroyCurrentMessageLoop` only [if we had a `DestructionObserver` registered](https://searchfox.org/mozilla-central/rev/fb8d77331582639ea6848a61dd8ee812fac31b77/ipc/chromium/src/base/message_loop.cc#269-270). So my doubt would be that the normal flow unregisters that observer before we get into `MessageLoop::~MessageLoop` and that if we get here with a registered observer we always block?