Bug 1731156 Comment 1 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
For the record, crashing in `WlCrashHandler()` is intentional and before bug 1726923 AFAICS[1][2] this would have been a "silent" crash, only printing "Error [...] dispatching to Wayland display." on the console and not spawning the crash reporter.

So great that we now catch it. I guess a more descriptive bug title would be "error marshalling arguments for start_drag (signature ?oo?ou): null value passed for arg 1" though, as that's the specific bug. "Crash in [@ mozilla::widget::WlCrashHandler]" will, for now, always happen for protocol errors, no matter which one.

1: https://gitlab.freedesktop.org/wayland/wayland/-/blob/main/src/connection.c#L668-672
2: https://gitlab.freedesktop.org/wayland/wayland/-/blob/main/src/wayland-client.c#L842-845
3: https://gitlab.gnome.org/GNOME/gtk/-/blob/gtk-3-24/gdk/wayland/gdkeventsource.c#L201-205
Revision 1 by
on 
For the record, crashing in `WlCrashHandler()` is intentional and before bug 1726923 AFAICS[1][2][3] this would have been a "silent" crash, only printing "Error [...] dispatching to Wayland display." on the console and not spawning the crash reporter.

So great that we now catch it. I guess a more descriptive bug title would be "error marshalling arguments for start_drag (signature ?oo?ou): null value passed for arg 1" though, as that's the specific bug. "Crash in [@ mozilla::widget::WlCrashHandler]" will, for now, always happen for protocol errors, no matter which one.

1: https://gitlab.freedesktop.org/wayland/wayland/-/blob/main/src/connection.c#L668-672
2: https://gitlab.freedesktop.org/wayland/wayland/-/blob/main/src/wayland-client.c#L842-845
3: https://gitlab.gnome.org/GNOME/gtk/-/blob/gtk-3-24/gdk/wayland/gdkeventsource.c#L201-205

Back to Bug 1731156 Comment 1