Andrei points out that have a pref in play here has problems:
> It makes sense but this is still really fragile (and can trick us into thinking it's fixed): we can still launch CFRs, infobars and any number of campaigns that promote VPN. We can also launch campaigns that have nothing to do with the captive portal trigger and instead open the URL for Mozilla VPN. I still think the best way to handle this is in experiment/message targeting.
I'm realizing now that the pref isn't the requirement itself; rather, it's a way to ensure correct behavior in repacks for partners and regions, which is probably close to the actual requirement. So I'll think on this a bit more, and clarify the requirements before I get them reviewed by the various stakeholders.
Bug 1731176 Comment 1 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Andrei points out that having a pref in play here has problems:
> It makes sense but this is still really fragile (and can trick us into thinking it's fixed): we can still launch CFRs, infobars and any number of campaigns that promote VPN. We can also launch campaigns that have nothing to do with the captive portal trigger and instead open the URL for Mozilla VPN. I still think the best way to handle this is in experiment/message targeting.
I'm realizing now that the pref isn't the requirement itself; rather, it's a way to ensure correct behavior in repacks for partners and regions, which is closer to the actual requirement. So I'll think on this a bit more, and clarify the requirements more before I get them reviewed by the various stakeholders.
Andrei points out that having a pref in play here has problems:
> It makes sense but this is still really fragile (and can trick us into thinking it's fixed): we can still launch CFRs, infobars and any number of campaigns that promote VPN. We can also launch campaigns that have nothing to do with the captive portal trigger and instead open the URL for Mozilla VPN. I still think the best way to handle this is in experiment/message targeting.
I'm realizing now that the pref isn't the requirement itself; rather, it's a way to try to ensure correct behavior in repacks for partners and regions, which is closer to the actual requirement. So I'll think on this a bit more, and clarify the requirements more before I get them reviewed by the various stakeholders.