Bug 1733422 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

[SessionStore.getClosedWindowData](https://searchfox.org/mozilla-central/search?q=getClosedWindowData&path=&case=false&regexp=false) is only called in production code with the `aAsString` argument as false.

In test code, the majority of tests call `JSON.parse` to translate the string back into an object.

We can therefore drop the string option, and have it always return an object. Note this is split out from bug 1505572.

I'm happy to mentor this. For instructions on how to get your local build of Firefox up and running and submit your patch, see https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html

Note this bug will be auto-assigned when the first patch is attached.
[SessionStore.getClosedWindowData](https://searchfox.org/mozilla-central/search?q=getClosedWindowData&path=&case=false&regexp=false) is only called in production code with the `aAsString` argument as false.

In test code, the majority of tests call `JSON.parse` to translate the string back into an object.

We can therefore drop the string option, and have it always return an object. Note this is split out from bug 1505572.

For running tests (after building), you'll want to do `./mach mochitest path/to/test`.

I'm happy to mentor this. For instructions on how to get your local build of Firefox up and running and submit your patch, see https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html

Note this bug will be auto-assigned when the first patch is attached.

Back to Bug 1733422 Comment 0