This is the part 1 patch for mozilla-release/92. For the patch that landed on m-c and m-b, there's a small conflict in browser/components/urlbar/tests/unit/xpcshell.ini due to bug 1739847. Approval Request Comment [Feature/Bug causing the regression]: [User impact if declined]: We need this for the Firefox Suggest preferences redesign targeting 95/94. [Is this code covered by automated tests?]: Yes [Has the fix been verified in Nightly?]: Yes [Needs manual test from QE? If yes, steps to reproduce]: Yes, please see the test plan doc [List of other uplifts needed for the feature/fix]: Please see uplift spreadsheet: https://docs.google.com/spreadsheets/d/1LavihS-VOPFYEyum7mrx6FKXmuQeHi9xQHfGNSxjnoY/edit?usp=sharing [Is the change risky?]: Medium risk [Why is the change risky/not risky?]: These are large patches that affects the Firefox Suggest feature, which is currently enabled by default for all U.S. users. There isn't much if any risk w/r/t affecting other Firefox features. For Firefox Suggest, the risk involves making sure we respect user choices and don't override them with future Firefox Suggest experiments or rollouts. These patches have comprehensive automated tests and we have a thorough test plan for making sure they work correctly and we respect user choice. [String changes made/needed]:
Bug 1735976 Comment 26 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
This is the part 1 patch for mozilla-release/94. For the patch that landed on m-c and m-b, there's a small conflict in browser/components/urlbar/tests/unit/xpcshell.ini due to bug 1739847. Approval Request Comment [Feature/Bug causing the regression]: [User impact if declined]: We need this for the Firefox Suggest preferences redesign targeting 95/94. [Is this code covered by automated tests?]: Yes [Has the fix been verified in Nightly?]: Yes [Needs manual test from QE? If yes, steps to reproduce]: Yes, please see the test plan doc [List of other uplifts needed for the feature/fix]: Please see uplift spreadsheet: https://docs.google.com/spreadsheets/d/1LavihS-VOPFYEyum7mrx6FKXmuQeHi9xQHfGNSxjnoY/edit?usp=sharing [Is the change risky?]: Medium risk [Why is the change risky/not risky?]: These are large patches that affects the Firefox Suggest feature, which is currently enabled by default for all U.S. users. There isn't much if any risk w/r/t affecting other Firefox features. For Firefox Suggest, the risk involves making sure we respect user choices and don't override them with future Firefox Suggest experiments or rollouts. These patches have comprehensive automated tests and we have a thorough test plan for making sure they work correctly and we respect user choice. [String changes made/needed]: