Bug 1739139 Comment 8 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

There are several parts to this that I think are best handled in individual bugs/patches. So I'm going to morph this one to be specifically about the glyph-topsites-16.svg icon used by newtab:

`browser/components/newtab/data/content/assets/glyph-topsites-16.svg`   should be moved to `browser/themes/shared/icons` and named `topsites.svg`. 
  - please use `hg mv` or its git equivalent to move the file so we retain commit history. 
  - You will need to update the `browser/themes/shared/jar.inc.mn` manifest (please maintain alphabetical sorting) to include the new .svg file
  - you'll need to find and update [all references](https://searchfox.org/mozilla-central/search?q=glyph-topsites-16.svg&path=) to point at `chrome://global/skin/icons/topsites.svg`
  - See the [docs for hacking on newtab](https://firefox-source-docs.mozilla.org/browser/components/newtab/docs/index.html#building-assets-and-running-firefox for details on how to edit CSS and refresh the bundle

You should always build and run with your changes to verify them. In this case I don't believe there is an easy way to see the `.icon-topsites` class in use, but you can check that `chrome://global/skin/icons/topsites.svg` resolve to the correct icon when entered into the url bar.
There are several parts to this that I think are best handled in individual bugs/patches. So I'm going to morph this one to be specifically about the glyph-topsites-16.svg icon used by newtab:

`browser/components/newtab/data/content/assets/glyph-topsites-16.svg`   should be moved to `browser/themes/shared/icons` and named `topsites.svg`. 
  - please use `hg mv` or its git equivalent to move the file so we retain commit history. 
  - You will need to update the `browser/themes/shared/jar.inc.mn` manifest (please maintain alphabetical sorting) to include the new .svg file
  - you'll need to find and update [all references](https://searchfox.org/mozilla-central/search?q=glyph-topsites-16.svg&path=) to point at `chrome://global/skin/icons/topsites.svg`
  - See the [docs for hacking on newtab](https://firefox-source-docs.mozilla.org/browser/components/newtab/docs/index.html#building-assets-and-running-firefox) for details on how to edit CSS and refresh the bundle

You should always build and run with your changes to verify them. In this case I don't believe there is an easy way to see the `.icon-topsites` class in use, but you can check that `chrome://global/skin/icons/topsites.svg` resolve to the correct icon when entered into the url bar.
There are several parts to this that I think are best handled in individual bugs/patches. So I'm going to morph this one to be specifically about the glyph-topsites-16.svg icon used by newtab:

`browser/components/newtab/data/content/assets/glyph-topsites-16.svg`   should be moved to `browser/themes/shared/icons` and named `topsites.svg`. 
  - please use `hg mv` or its git equivalent to move the file so we retain commit history. 
  - You will need to update the `browser/themes/shared/jar.inc.mn` manifest (please maintain alphabetical sorting) to include the new .svg file
  - you'll need to find and update [all references](https://searchfox.org/mozilla-central/search?q=glyph-topsites-16.svg&path=) to point at `chrome://browser/skin/topsites.svg`
  - See the [docs for hacking on newtab](https://firefox-source-docs.mozilla.org/browser/components/newtab/docs/index.html#building-assets-and-running-firefox) for details on how to edit CSS and refresh the bundle

You should always build and run with your changes to verify them. In this case I don't believe there is an easy way to see the `.icon-topsites` class in use, but you can check that `chrome://browser/skin/topsites.svg` resolve to the correct icon when entered into the url bar.

Back to Bug 1739139 Comment 8