Bug 1744975 Comment 24 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

I think I'd prefer implementing these builtins in self-hosted code, at least for now, without changing the existing Array builtins. This is all very perf-sensitive code so touching it as little as possible would be less risk for us.

I also think we should rely less on records/tuples being implemented as objects, as that should be just an implementation detail. For instance if we ever decide to implement records/tuples without using `JSObject` (similar to how `JSString` or `BigInt` don't use `JSObject`), ideally we wouldn't have to change much. I've been proposing we branch on the `Value` type more than on the object's class, but there are still some places I'd like to convert to that scheme.
I think I'd prefer implementing these builtins in self-hosted code, at least for now, without changing the existing Array builtins. This is all very perf-sensitive code so touching it as little as possible would be less risk for us.

I also think we should rely less on records/tuples being implemented as objects, as that should be just an implementation detail. For instance if we ever decide to implement records/tuples without using `JSObject` (similar to how `JSString` and `BigInt` don't use `JSObject`), ideally we wouldn't have to change much. I've been proposing we branch on the `Value` type more than on the object's class, but there are still some places I'd like to convert to that scheme.

Back to Bug 1744975 Comment 24