Bug 1748788 Comment 6 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
I did track down what's going on.  The crash actually happens at this [debug_assert!(info.ignore_missing_pipeline)](https://searchfox.org/mozilla-central/rev/d107bc8aeadcc816ba85cb21c1a6a1aac1d4ef9f/gfx/wr/webrender/src/scene_building.rs#947) assert.  The missing pipeline id comes from [this PushIFrame](https://searchfox.org/mozilla-central/rev/d107bc8aeadcc816ba85cb21c1a6a1aac1d4ef9f/gfx/layers/wr/WebRenderUserData.cpp#228) command in WebRenderImageData::CreateAsyncImageWebRenderCommands. The pipeline id in [Scene.pipeline](https://searchfox.org/mozilla-central/rev/d107bc8aeadcc816ba85cb21c1a6a1aac1d4ef9f/gfx/wr/webrender/src/scene.rs#188) has already been in fact removed
 by the ClearCachedWebrenderResources call introduced in bug 1742797.

I believe this is a pre-existing issue, because when we recreate popup we [do call ClearCachedWebrenderResources](https://searchfox.org/mozilla-central/rev/d107bc8aeadcc816ba85cb21c1a6a1aac1d4ef9f/layout/xul/nsMenuPopupFrame.cpp#302) and it [happens on Macs if the device has multiple screen](https://searchfox.org/mozilla-central/rev/d107bc8aeadcc816ba85cb21c1a6a1aac1d4ef9f/widget/cocoa/nsCocoaWindow.mm#1078).

CCing sotaro.
Revision 1 by
on 
I did track down what's going on.  The crash actually happens at this [debug_assert!(info.ignore_missing_pipeline)](https://searchfox.org/mozilla-central/rev/d107bc8aeadcc816ba85cb21c1a6a1aac1d4ef9f/gfx/wr/webrender/src/scene_building.rs#947) assert.  The missing pipeline id comes from [this PushIFrame](https://searchfox.org/mozilla-central/rev/d107bc8aeadcc816ba85cb21c1a6a1aac1d4ef9f/gfx/layers/wr/WebRenderUserData.cpp#228) command in WebRenderImageData::CreateAsyncImageWebRenderCommands. The pipeline id in [Scene.pipeline](https://searchfox.org/mozilla-central/rev/d107bc8aeadcc816ba85cb21c1a6a1aac1d4ef9f/gfx/wr/webrender/src/scene.rs#188) has already been in fact removed by the ClearCachedWebrenderResources call introduced in bug 1742797.

I believe this is a pre-existing issue, because when we recreate popup we [do call ClearCachedWebrenderResources](https://searchfox.org/mozilla-central/rev/d107bc8aeadcc816ba85cb21c1a6a1aac1d4ef9f/layout/xul/nsMenuPopupFrame.cpp#302) and it [happens on Macs if the device has multiple screen](https://searchfox.org/mozilla-central/rev/d107bc8aeadcc816ba85cb21c1a6a1aac1d4ef9f/widget/cocoa/nsCocoaWindow.mm#1078).

CCing sotaro.

Back to Bug 1748788 Comment 6