(In reply to Shazib Summar [:ssummar] from comment #5) > (In reply to Nick Alexander :nalexander [he/him] from comment #4) > > (In reply to Nick Alexander :nalexander [he/him] from comment #3) > > > What a world we live in. I've done some digging, and it's possible that the changes over in Bug 1617283 will address this. Let's wait for that to reland and retest. If that's not enough, we'll have to disable this audio session stuff in background task mode separately. > > > > Actually, we still need to disable this, I think. That would be making [this call to `StartAudioSession`](https://searchfox.org/mozilla-central/rev/8e1eb5cbd89a2455c34032d921f8de28261d016b/widget/windows/nsAppShell.cpp#594) conditional. > > Hi there. You're right, the patch for bug 1617283 doesn't fix this issue. I would like to work on this. Could you kindly give me some pointers as where to start? Specifically could you kindly elaborate on your last comment? Sure. The first step will be to repro (which I can do locally, FYI). This was easiest to witness by enabling the old Volume Mixer control (which I did following [these instructions](https://tweaks.com/windows/67204/bring-back-the-classic-volume-mixer-in-windows-10/)). Then, build a full (compiled) Firefox. Run `mach run --backgroundtask success --attach-console`. If you do that a few times, you should see new volume controls being added, just like the reporter says. To address this, don't [`StartAudioSession`](https://searchfox.org/mozilla-central/rev/8e1eb5cbd89a2455c34032d921f8de28261d016b/widget/windows/nsAppShell.cpp#594) when we're in a background task, using a check [like this one](https://searchfox.org/mozilla-central/rev/9f61d854547cedbde0773b2893e4f925352be3b3/startupcache/StartupCache.cpp#121-125). In addition, don't [`StopAudioSession`](https://searchfox.org/mozilla-central/rev/9f61d854547cedbde0773b2893e4f925352be3b3/toolkit/xre/nsAppRunner.cpp#5924), either. Then verify that you don't get volume columns with your new changes. Thanks!
Bug 1753603 Comment 6 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
(In reply to Shazib Summar [:ssummar] from comment #5) > (In reply to Nick Alexander :nalexander [he/him] from comment #4) > > (In reply to Nick Alexander :nalexander [he/him] from comment #3) > > > What a world we live in. I've done some digging, and it's possible that the changes over in Bug 1617283 will address this. Let's wait for that to reland and retest. If that's not enough, we'll have to disable this audio session stuff in background task mode separately. > > > > Actually, we still need to disable this, I think. That would be making [this call to `StartAudioSession`](https://searchfox.org/mozilla-central/rev/8e1eb5cbd89a2455c34032d921f8de28261d016b/widget/windows/nsAppShell.cpp#594) conditional. > > Hi there. You're right, the patch for bug 1617283 doesn't fix this issue. I would like to work on this. Could you kindly give me some pointers as where to start? Specifically could you kindly elaborate on your last comment? Sure. The first step will be to repro (which I can do locally, FYI). This was easiest to witness by enabling the old Volume Mixer control (which I did following [these instructions](https://tweaks.com/windows/67204/bring-back-the-classic-volume-mixer-in-windows-10/)). Then, build a full (compiled) Firefox. Run `mach run --backgroundtask success --attach-console`. If you do that a few times, you should see new volume controls being added, just like the reporter says. To address this, don't [`StartAudioSession`](https://searchfox.org/mozilla-central/rev/8e1eb5cbd89a2455c34032d921f8de28261d016b/widget/windows/nsAppShell.cpp#594) when we're in a background task, using a check [like this one](https://searchfox.org/mozilla-central/rev/9f61d854547cedbde0773b2893e4f925352be3b3/startupcache/StartupCache.cpp#121-125). In addition, don't [`StopAudioSession`](https://searchfox.org/mozilla-central/rev/9f61d854547cedbde0773b2893e4f925352be3b3/toolkit/xre/nsAppRunner.cpp#5924), either. Then verify that you don't get volume controls with your new changes. Thanks!