Bug 1757647 Comment 4 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

You should remove the call. COM gets initialised in mscom::ProcessRuntime, which now happens very early in startup in mozglue. I'm assuming this happens much later than that, but if you do need COM initialised earlier, we'll need to move ProcessRuntime construction; we don't want other stuff initialising COM first.

Some older code does still call CoInitialize/RoInitialize, but that should be considered legacy, hence the whitelist.

As a side note, calling RoInitialize with RO_INIT_MULTITHREADED is an error here anyway because the main thread is (and must be) a single threaded apartment (STA).
You should remove the call. COM gets initialised in mscom::ProcessRuntime, which now happens very early in startup in mozglue. I'm assuming this new code happens much later than that, but if you do need COM initialised earlier, we'll need to move ProcessRuntime construction; we don't want other stuff initialising COM first.

Some older code does still call CoInitialize/RoInitialize, but that should be considered legacy, hence the whitelist.

As a side note, calling RoInitialize with RO_INIT_MULTITHREADED is an error here anyway because the main thread is (and must be) a single threaded apartment (STA).
You should remove the call. COM gets initialised in mscom::ProcessRuntime, which now happens very early in startup in mozglue. I'm assuming this new code happens much later than that, but if you do need COM initialised earlier, we'll need to move ProcessRuntime construction; we don't want other stuff initialising COM first.

Some older code does still call CoInitialize/RoInitialize, but that should be considered legacy, hence the whitelist.

As a side note, calling RoInitialize with RO_INIT_MULTITHREADED is an error here anyway because the parent process main thread is (and must be) a single threaded apartment (STA).

Back to Bug 1757647 Comment 4