It would perhaps also be worth turning one or both of comment 0 / comment 7 into WPT tests. The existing WPT testing here (from `contain-inline-size-bfc-floats-001.html` and from boris's added tests) all use some variety of bespoke modern CSS features (either `contain:inline-size` or `aspect-ratio`), whereas David's tests here are nicely generalized such that they don't rely on those features, which makes them worth adding to WPT I think (i.e. I wouldn't consider them redundant/duplicative). David, would you mind doing that? (That could happen as a tests-only patch on this bug here. It's fine that this bug is closed; you should still be able to post a phabricator patch here just as you usually would.)
Bug 1763431 Comment 11 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
It would perhaps also be worth turning one or both of comment 0 / comment 7 into WPT tests. The existing WPT testing here (from `contain-inline-size-bfc-floats-001.html` and from [boris's added test](https://hg.mozilla.org/mozilla-central/rev/fb1114750895#l7.3)) all use some variety of bespoke modern CSS features (either `contain:inline-size` or `aspect-ratio`), whereas David's tests here are nicely generalized such that they don't rely on those features, which makes them worth adding to WPT I think (i.e. I wouldn't consider them redundant/duplicative). David, would you mind doing that? (That could happen as a tests-only patch on this bug here. It's fine that this bug is closed; you should still be able to post a phabricator patch here just as you usually would.)
It would perhaps also be worth turning one or both of comment 0 / comment 7 into WPT tests. The existing WPT testing here (from `contain-inline-size-bfc-floats-001.html` and from [boris's added test](https://hg.mozilla.org/mozilla-central/rev/fb1114750895#l7.3)) all use some variety of bespoke modern CSS features (either `contain:inline-size` or `aspect-ratio`), whereas David's tests here are nicely generalized such that they don't rely on those features, which makes them worth adding to WPT I think (i.e. I wouldn't consider them redundant/duplicative). David, would you mind doing that? (That could happen as a tests-only patch on this bug here. It's fine that this bug is closed; you should still be able to post a phabricator patch here just as you usually would -- just adding tests, in this case.