Bug 1768346 Comment 12 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

I think I still need some hints. Even after extensive staring at part 3, I still don't have a clue where things go awry.

Looking at code coverage to spot any code paths which aren't tested, I see that the [IsTestInputMaybeToBool](https://coverage.moz.tools/#revision=1d8e241079027fc61c22bd14c4bbc6c3cfb4e6c5&path=js%2Fsrc%2Fjit%2FIonAnalysis.cpp&view=file&line=1079) code paths aren't covered. Applies both for the triangle and the diamond pattern, because in [IsTestInputMaybeToBool](https://coverage.moz.tools/#revision=1d8e241079027fc61c22bd14c4bbc6c3cfb4e6c5&path=js%2Fsrc%2Fjit%2FIonAnalysis.cpp&view=file&line=662) we never return `true`. But when I created some local tests to execute these code paths, I couldn't spot any obvious issues.
> Does that help, André? I could try to narrow it down more with more try pushes...

I think I still need some hints. Even after extensive staring at part 3, I still don't have a clue where things go awry.

Looking at code coverage to spot any code paths which aren't tested, I see that the [IsTestInputMaybeToBool](https://coverage.moz.tools/#revision=1d8e241079027fc61c22bd14c4bbc6c3cfb4e6c5&path=js%2Fsrc%2Fjit%2FIonAnalysis.cpp&view=file&line=1079) code paths aren't covered. Applies both for the triangle and the diamond pattern, because in [IsTestInputMaybeToBool](https://coverage.moz.tools/#revision=1d8e241079027fc61c22bd14c4bbc6c3cfb4e6c5&path=js%2Fsrc%2Fjit%2FIonAnalysis.cpp&view=file&line=662) we never return `true`. But when I created some local tests to execute these code paths, I couldn't spot any obvious issues.

Back to Bug 1768346 Comment 12