Bug 1769669 Comment 10 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Should I prepare a patch for the Remote Settings counter part or will you do it as part of this bug?

Basically, I'm thinking of adding an `AppConstant` with the prod root hash, and then rely on the same preference as before on Dev/Nightly.

This would roughly look this:

```diff
diff --git a/services/settings/Utils.jsm b/services/settings/Utils.jsm
--- a/services/settings/Utils.jsm
+++ b/services/settings/Utils.jsm
@@ -106,6 +106,12 @@ var Utils = {
       : AppConstants.REMOTE_SETTINGS_SERVER_URL;
   },

+  get ROOT_HASH() {
+    return allowServerURLOverride
+      ? Services.prefs.getCharPref("security.content.signature.root_hash")
+      : AppConstants.REMOTE_SETTINGS_ROOT_HASH;
+  },
+
```
Should I prepare a patch for the Remote Settings counter part or will you do it as part of this bug?

Basically, I'm thinking of adding an `AppConstant` with the prod root hash, and then rely on the same preference as before on Dev/Nightly.

This would roughly look like this:

```diff
diff --git a/services/settings/Utils.jsm b/services/settings/Utils.jsm
--- a/services/settings/Utils.jsm
+++ b/services/settings/Utils.jsm
@@ -106,6 +106,12 @@ var Utils = {
       : AppConstants.REMOTE_SETTINGS_SERVER_URL;
   },

+  get ROOT_HASH() {
+    return allowServerURLOverride
+      ? Services.prefs.getCharPref("security.content.signature.root_hash")
+      : AppConstants.REMOTE_SETTINGS_ROOT_HASH;
+  },
+
```

Back to Bug 1769669 Comment 10