Bug 1770483 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Bug 1597791 deprecated the `urlbar.picked.autofill` scalar in favor of three new scalars, but there are a few other types of autofill results we forgot about:

* about pages (UrlbarProviderAutofill)
* Search engine domains (UrlbarProviderAutofill)
* Preloaded top sites (UrlbarProviderPreloadedSites)
* Token alias engines (UrlbarProviderTokenAliasEngines)

For example, if you autofill "about:config" and press enter, a couple of errors will be logged:

> urlbar.picked.autofill_undefined - Unknown scalar. 
> Unsupported telemetry type autofill_undefined

We could add a general `autofill_other` fallback, but we should probably add individual types/scalars for all these.
Bug 1597791 deprecated the `urlbar.picked.autofill` scalar in favor of three new scalars, but there are a few other types of autofill results we forgot about:

* about pages (UrlbarProviderAutofill)
* ~~Search engine domains (UrlbarProviderAutofill)~~ [1]
* Preloaded top sites (UrlbarProviderPreloadedSites)
* ~~Token alias engines (UrlbarProviderTokenAliasEngines)~~ [1]

For example, if you autofill "about:config" and press enter, a couple of errors will be logged:

> urlbar.picked.autofill_undefined - Unknown scalar. 
> Unsupported telemetry type autofill_undefined

We could add a general `autofill_other` fallback, but we should probably add individual types/scalars for all these.

[1] Edit: Actually search engine domain autofill and token alias engine autofill are not currently reported as autofill in telemetry. That's because those results aren't URL results, and [only URL results can be reported as autofill](https://searchfox.org/mozilla-central/rev/8bd5597baef9be63fc4689a69e550d607dc68444/browser/components/urlbar/UrlbarUtils.jsm#1188-1191). That logic goes back a ways and I don't want to litigate it now, so I'll drop these two from this bug.

Back to Bug 1770483 Comment 0