(In reply to Alessandro Castellani [:aleca] from comment #3) > Rather than showing a dialog, the form should have some default `required` fields to leverage the built-in HTML5 form validation, and go through that before saving the contact. I don't think that's a good solution, unless if you have a way natively requiring that from a range of fields, one must be filled. We don't want to force users to enter data which they may not have or are not willing to add at this point. As the current error message says (see screenshot above), it's probably totally sufficient if any *one* of the following fields is filled: Email Address, First Name, Last Name, Display Name, Organization. https://searchfox.org/comm-central/rev/3a39d40958129613df4353604f04c9d32519e848/mail/locales/en-US/chrome/messenger/addressbook/addressBook.properties#28 > cardRequiredDataMissingMessage=You must enter at least one of the following items:\nEmail Address, First Name, Last Name, Display Name, Organization. > We might also consider disabling the "Save" button until the form is valid. While this might look like a superior solution, it is not. Again assuming that `required` isn't what we want here because it's way too strict, it's actually much clearer to to the user to just show an explicit error message. I think this error message won't happen very often - saving an empty contact is really just a rare accident, maybe when you got interrupted and don't realize you have entered nothing. I think we're casting the error message so that you don't end up in a false belief that you have actually saved a contact with data. > I'll take care of this. Thank you.
Bug 1771575 Comment 5 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
(In reply to Alessandro Castellani [:aleca] from comment #3) > Rather than showing a dialog, the form should have some default `required` fields to leverage the built-in HTML5 form validation, and go through that before saving the contact. I don't think that's a good solution, unless if you have a way of natively requiring that from a range of fields, one must be filled. We don't want to force users to enter data which they may not have or are not willing to add at this point. As the current error message says (see screenshot above), it's probably totally sufficient if any *one* of the following fields is filled: Email Address, First Name, Last Name, Display Name, Organization. https://searchfox.org/comm-central/rev/3a39d40958129613df4353604f04c9d32519e848/mail/locales/en-US/chrome/messenger/addressbook/addressBook.properties#28 > cardRequiredDataMissingMessage=You must enter at least one of the following items:\nEmail Address, First Name, Last Name, Display Name, Organization. > We might also consider disabling the "Save" button until the form is valid. While this might look like a superior solution, it is not. Again assuming that `required` isn't what we want here because it's way too strict, it's actually much clearer to to the user to just show an explicit error message. I think this error message won't happen very often - saving an empty contact is really just a rare accident, maybe when you got interrupted and don't realize you have entered nothing. I think we're casting the error message so that you don't end up in a false belief that you have actually saved a contact with data. > I'll take care of this. Thank you.
(In reply to Alessandro Castellani [:aleca] from comment #3) > Rather than showing a dialog, the form should have some default `required` fields to leverage the built-in HTML5 form validation, and go through that before saving the contact. I don't think that's a good solution, unless if you have a way of natively requiring that from a range of fields, one must be filled. We don't want to force users to enter data which they may not have or are not willing to add at this point. As the current error message suggests (see screenshot above), it looks totally sufficient if any *one* of the following fields is filled: Email Address, First Name, Last Name, Display Name, Organization. https://searchfox.org/comm-central/rev/3a39d40958129613df4353604f04c9d32519e848/mail/locales/en-US/chrome/messenger/addressbook/addressBook.properties#28 > cardRequiredDataMissingMessage=You must enter at least one of the following items:\nEmail Address, First Name, Last Name, Display Name, Organization. > We might also consider disabling the "Save" button until the form is valid. While this might look like a superior solution, it is not. Again assuming that `required` isn't what we want here because it's way too strict, it's actually much clearer to to the user to just show an explicit error message. I think this error message won't happen very often - saving an empty contact is really just a rare accident, maybe when you got interrupted and don't realize you have entered nothing. I think we're casting the error message so that you don't end up in a false belief that you have actually saved a contact with data. > I'll take care of this. Thank you.
(In reply to Alessandro Castellani [:aleca] from comment #3) > Rather than showing a dialog, the form should have some default `required` fields to leverage the built-in HTML5 form validation, and go through that before saving the contact. I don't think that's a good solution, unless you have a way of natively requiring that from a range of fields, one must be filled. We don't want to force users to enter data which they may not have or are not willing to add at this point. As the current error message suggests (see screenshot above), it looks totally sufficient if any *one* of the following fields is filled: Email Address, First Name, Last Name, Display Name, Organization. https://searchfox.org/comm-central/rev/3a39d40958129613df4353604f04c9d32519e848/mail/locales/en-US/chrome/messenger/addressbook/addressBook.properties#28 > cardRequiredDataMissingMessage=You must enter at least one of the following items:\nEmail Address, First Name, Last Name, Display Name, Organization. > We might also consider disabling the "Save" button until the form is valid. While this might look like a superior solution, it is not. Again assuming that `required` isn't what we want here because it's way too strict, it's actually much clearer to to the user to just show an explicit error message. I think this error message won't happen very often - saving an empty contact is really just a rare accident, maybe when you got interrupted and don't realize you have entered nothing. I think we're casting the error message so that you don't end up in a false belief that you have actually saved a contact with data. > I'll take care of this. Thank you.
(In reply to Alessandro Castellani [:aleca] from comment #3) > Rather than showing a dialog, the form should have some default `required` fields to leverage the built-in HTML5 form validation, and go through that before saving the contact. I don't think that's a good solution, unless you have a way of natively requiring that from a *range* of fields, *only one* must be filled. We don't want to force users to enter data which they may not have or are not willing to add at this point. As the current error message suggests (see screenshot above), it looks totally sufficient if any *one* of the following fields is filled: Email Address, First Name, Last Name, Display Name, Organization. https://searchfox.org/comm-central/rev/3a39d40958129613df4353604f04c9d32519e848/mail/locales/en-US/chrome/messenger/addressbook/addressBook.properties#28 > cardRequiredDataMissingMessage=You must enter at least one of the following items:\nEmail Address, First Name, Last Name, Display Name, Organization. > We might also consider disabling the "Save" button until the form is valid. While this might look like a superior solution, it is not. Again assuming that `required` isn't what we want here because it's way too strict, it's actually much clearer to to the user to just show an explicit error message. I think this error message won't happen very often - saving an empty contact is really just a rare accident, maybe when you got interrupted and don't realize you have entered nothing. I think we're casting the error message so that you don't end up in a false belief that you have actually saved a contact with data. > I'll take care of this. Thank you.
(In reply to Alessandro Castellani [:aleca] from comment #3) > Rather than showing a dialog, the form should have some default `required` fields to leverage the built-in HTML5 form validation, and go through that before saving the contact. I don't think that's a good solution, unless you have a way of natively requiring that from a *range* of fields, *only one* must be filled. We don't want to force users to enter data which they may not have or are not willing to add at this point. As the current error message suggests (see screenshot above), it looks totally sufficient if any *one* of the following fields is filled: Email Address, First Name, Last Name, Display Name, Organization. https://searchfox.org/comm-central/rev/3a39d40958129613df4353604f04c9d32519e848/mail/locales/en-US/chrome/messenger/addressbook/addressBook.properties#28 > cardRequiredDataMissingMessage=You must enter at least one of the following items:\nEmail Address, First Name, Last Name, Display Name, Organization. > We might also consider disabling the "Save" button until the form is valid. While this might look like a superior solution, imo it is not. Again assuming that `required` isn't what we want here because it's way too strict, it's actually much clearer to to the user to just show an explicit error message. I think this error message won't happen very often - saving an empty contact is really just a rare accident, maybe when you got interrupted and don't realize you have entered nothing. I think we're casting the error message so that you don't end up in a false belief that you have actually saved a contact with data. > I'll take care of this. Thank you.
(In reply to Alessandro Castellani [:aleca] from comment #3) > Rather than showing a dialog, the form should have some default `required` fields to leverage the built-in HTML5 form validation, and go through that before saving the contact. I don't think that's a good solution, unless you have a way of natively requiring that from a *range* of fields, *only one* must be filled. We don't want to force users to enter data which they may not have or are not willing to add at this point. As the current error message suggests (see screenshot above), it looks totally sufficient if any *one* of the following fields is filled: Email Address, First Name, Last Name, Display Name, Organization. https://searchfox.org/comm-central/rev/3a39d40958129613df4353604f04c9d32519e848/mail/locales/en-US/chrome/messenger/addressbook/addressBook.properties#28 > cardRequiredDataMissingMessage=You must enter at least one of the following items:\nEmail Address, First Name, Last Name, Display Name, Organization. > We might also consider disabling the "Save" button until the form is valid. While this might look like a superior solution, imo it is not. Again assuming that `required` isn't what we want here because it's way too strict, it's actually much clearer to to the user to just show an explicit error message. I think this error message won't happen very often - saving an empty contact is really just a rare accident, maybe when you got interrupted and don't realize you have entered nothing. I think we're casting the error message so that you don't end up in a false belief that you have actually saved a contact with data. The error message is much clearer as it explicitly tells the user what's wrong and how to fix it. I don't think any markup like red borders on fields could do this, because how would you indicate that only one out of several marked fields must be filled? > I'll take care of this. Thank you.
(In reply to Alessandro Castellani [:aleca] from comment #3) > Rather than showing a dialog, the form should have some default `required` fields to leverage the built-in HTML5 form validation, and go through that before saving the contact. I don't think that's a good solution, unless you have a way of natively requiring that from a *range* of fields, *only one* must be filled. We don't want to force users to enter data which they may not have or are not willing to add at this point. As the current error message suggests (see screenshot above), it looks totally sufficient if any *one* of the following fields is filled: Email Address, First Name, Last Name, Display Name, Organization. https://searchfox.org/comm-central/rev/3a39d40958129613df4353604f04c9d32519e848/mail/locales/en-US/chrome/messenger/addressbook/addressBook.properties#28 > cardRequiredDataMissingMessage=You must enter at least one of the following items:\nEmail Address, First Name, Last Name, Display Name, Organization. > We might also consider disabling the "Save" button until the form is valid. While this might look like a superior solution, imo it is not. Again assuming that `required` isn't what we want here because it's way too strict, it's actually much clearer to to the user to just show an explicit error message. I think this error message won't happen very often - saving an empty contact is really just a rare accident, maybe when you got interrupted and don't realize you have entered nothing. I think we're casting the error message so that you don't end up in a false belief that you have actually saved a contact with data. The error message is much clearer as it explicitly tells the user what's wrong and how to fix it. I don't think any required-markup like red borders on fields could do this, because how would you indicate that only one out of several marked fields must be filled? > I'll take care of this. Thank you.