While reviewing https://phabricator.services.mozilla.com/D149665 I looked for 'advanced' in preferences code. This found me this set of things: https://searchfox.org/mozilla-central/search?q=advancedPrefs There's some CSS and 2 telemetry-related tests. In bug 1075055 we added some test(s) for telemetry and/or healthreport. In bug 1545552 we noticed that it wasn't running. But we kept a test that checks if `telemetry` is true. But from a quick look at [a random log file](https://firefoxci.taskcluster-artifacts.net/OYpwLtd8QEmcPXkHqsTKnA/0/public/logs/live_backing.log), telemetry is `false` anyway: ``` [task 2022-06-21T22:12:25.759Z] 22:12:25 INFO - telemetry: False ``` this makes sense (don't want test jobs sending telemetry), and anyway, AFAICT both browser_telemetry.js and browser_healthreport.js have been broken a while (they time out if run locally), because the `advancedPrefs` element which both rely on per the searchfox query above has not existed for a while now. Dexter, unless you object, I'd like to suggest removing all of this.
Bug 1775366 Comment 0 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
While reviewing https://phabricator.services.mozilla.com/D149665 I looked for 'advanced' in preferences code. This found me this set of things: https://searchfox.org/mozilla-central/search?q=advancedPrefs There's some CSS and 2 telemetry-related tests. In bug 1075055 we added some test(s) for telemetry and/or healthreport. In bug 1545552 we noticed that it wasn't running. But we kept a `skip-if` test in the manifest that checks if `telemetry` is true. But from a quick look at [a random log file](https://firefoxci.taskcluster-artifacts.net/OYpwLtd8QEmcPXkHqsTKnA/0/public/logs/live_backing.log), telemetry is `false` anyway: ``` [task 2022-06-21T22:12:25.759Z] 22:12:25 INFO - telemetry: False ``` this makes sense (don't want test jobs sending telemetry), and anyway, AFAICT both browser_telemetry.js and browser_healthreport.js have been broken a while (they time out if run locally), because the `advancedPrefs` element which both rely on per the searchfox query above has not existed for a while now. Dexter, unless you object, I'd like to suggest removing all of this.