Bug 1777921 Comment 5 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Norisz Fay [:noriszfay] from comment #4)
> Backed out causing multiple worker related failures 
> 
> [Backout link](https://hg.mozilla.org/integration/autoland/rev/da40d47ada4a520601db9f252581688d6132f02a)
> 
> [Push with failures - c2](https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception&fromchange=6bf69273ba54df0bda164bd74e6f7ea2358d10da&searchStr=os%2Cx%2C10.15%2Cwebrender%2Cdebug%2Cmochitests%2Cwith%2Cnetworking%2Con%2Csocket%2Cprocess%2Cwithout%2Ce10s%2Ctest-macosx1015-64-qr%2Fdebug-mochitest-chrome-spi-nw-1proc%2Cc2&tochange=b659224e6ab493b0297d1dd5649ba240c5d918f9&selectedTaskRun=WVmzzqHSQ1Stw6XaEukctQ.0)
> [Failure log - c2](https://treeherder.mozilla.org/logviewer?job_id=409660677&repo=autoland&lineNumber=131995)

Is "caused" by the new diagnostic assert from this patch. It seems the fix for bug 1538754 might cover this.

> [Push with failure - Wc](https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=MVtP2zp8SAqH2r7Z7IgDBg.0&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception&searchStr=android%2C7.0%2Cx86-64%2Cwebrender%2Cdebug%2Cweb%2Cplatform%2Ctests%2Ctest-android-em-7.0-x86_64-qr%2Fdebug-geckoview-web-platform-tests-crashtest%2Cwc&revision=b659224e6ab493b0297d1dd5649ba240c5d918f9)
> [Failure log - Wc](https://treeherder.mozilla.org/logviewer?job_id=409657746&repo=autoland&lineNumber=5973)

Is a [different assertion](https://hg.mozilla.org/integration/autoland/file/b659224e6ab493b0297d1dd5649ba240c5d918f9/dom/workers/RuntimeService.cpp#l2109) and I am kind of convinced it is unrelated to this patch, as if ever this patch makes us GCCC more often than before, so if its assertion is not triggered I see less probability for the global to stay alive, not more.
(In reply to Norisz Fay [:noriszfay] from comment #4)
> Backed out causing multiple worker related failures 
> 
> [Backout link](https://hg.mozilla.org/integration/autoland/rev/da40d47ada4a520601db9f252581688d6132f02a)
> 
> [Push with failures - c2](https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception&fromchange=6bf69273ba54df0bda164bd74e6f7ea2358d10da&searchStr=os%2Cx%2C10.15%2Cwebrender%2Cdebug%2Cmochitests%2Cwith%2Cnetworking%2Con%2Csocket%2Cprocess%2Cwithout%2Ce10s%2Ctest-macosx1015-64-qr%2Fdebug-mochitest-chrome-spi-nw-1proc%2Cc2&tochange=b659224e6ab493b0297d1dd5649ba240c5d918f9&selectedTaskRun=WVmzzqHSQ1Stw6XaEukctQ.0)
> [Failure log - c2](https://treeherder.mozilla.org/logviewer?job_id=409660677&repo=autoland&lineNumber=131995)

Is "caused" by the new diagnostic assert from this patch. It seems the fix for bug 1538754 might cover this.

> [Push with failure - Wc](https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=MVtP2zp8SAqH2r7Z7IgDBg.0&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception&searchStr=android%2C7.0%2Cx86-64%2Cwebrender%2Cdebug%2Cweb%2Cplatform%2Ctests%2Ctest-android-em-7.0-x86_64-qr%2Fdebug-geckoview-web-platform-tests-crashtest%2Cwc&revision=b659224e6ab493b0297d1dd5649ba240c5d918f9)
> [Failure log - Wc](https://treeherder.mozilla.org/logviewer?job_id=409657746&repo=autoland&lineNumber=5973)

Is a [different assertion](https://hg.mozilla.org/integration/autoland/file/b659224e6ab493b0297d1dd5649ba240c5d918f9/dom/workers/RuntimeService.cpp#l2109) and I am kind of convinced it is unrelated to this patch, as if ever this patch makes us GCCC more often than before, so if its own assertion is not triggered I see less probability for the global to stay alive, not more.
(In reply to Norisz Fay [:noriszfay] from comment #4)
> Backed out causing multiple worker related failures 
> 
> [Backout link](https://hg.mozilla.org/integration/autoland/rev/da40d47ada4a520601db9f252581688d6132f02a)
> 
> [Push with failures - c2](https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception&fromchange=6bf69273ba54df0bda164bd74e6f7ea2358d10da&searchStr=os%2Cx%2C10.15%2Cwebrender%2Cdebug%2Cmochitests%2Cwith%2Cnetworking%2Con%2Csocket%2Cprocess%2Cwithout%2Ce10s%2Ctest-macosx1015-64-qr%2Fdebug-mochitest-chrome-spi-nw-1proc%2Cc2&tochange=b659224e6ab493b0297d1dd5649ba240c5d918f9&selectedTaskRun=WVmzzqHSQ1Stw6XaEukctQ.0)
> [Failure log - c2](https://treeherder.mozilla.org/logviewer?job_id=409660677&repo=autoland&lineNumber=131995)

Is "caused" by the new diagnostic assert from this patch. It seems the fix for bug 1538754 might cover this.

> [Push with failure - Wc](https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=MVtP2zp8SAqH2r7Z7IgDBg.0&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception&searchStr=android%2C7.0%2Cx86-64%2Cwebrender%2Cdebug%2Cweb%2Cplatform%2Ctests%2Ctest-android-em-7.0-x86_64-qr%2Fdebug-geckoview-web-platform-tests-crashtest%2Cwc&revision=b659224e6ab493b0297d1dd5649ba240c5d918f9)
> [Failure log - Wc](https://treeherder.mozilla.org/logviewer?job_id=409657746&repo=autoland&lineNumber=5973)

Is a [different assertion](https://hg.mozilla.org/integration/autoland/file/b659224e6ab493b0297d1dd5649ba240c5d918f9/dom/workers/RuntimeService.cpp#l2109) and I am kind of convinced it should be unrelated to this patch, as if ever this patch makes us GCCC more often than before, so if its own assertion is not triggered I see less probability for the global to stay alive, not more.

Back to Bug 1777921 Comment 5