(In reply to Sotaro Ikeda [:sotaro away July/11 - July/19] from comment #0) > IDXGISwapChain3::SetColorSpace1() failure handling is wrong. > > Chromium does like the following. > https://source.chromium.org/chromium/chromium/src/+/main:ui/gl/swap_chain_presenter.cc;l=1375?q=SetColorSpace1&ss=chromium Current implementation is not wrong. chromium does nothing on the error.
Bug 1778622 Comment 2 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
(In reply to Sotaro Ikeda [:sotaro away July/11 - July/19] from comment #0) > IDXGISwapChain3::SetColorSpace1() failure handling is wrong. > > Chromium does like the following. > https://source.chromium.org/chromium/chromium/src/+/main:ui/gl/swap_chain_presenter.cc;l=1375?q=SetColorSpace1&ss=chromium Current implementation is not wrong. chromium does nothing on the error. On Firefox, it might be better to disable video overlay with the SetColorSpace1() error.
(In reply to Sotaro Ikeda [:sotaro away July/11 - July/19] from comment #0) > IDXGISwapChain3::SetColorSpace1() failure handling is wrong. > > Chromium does like the following. > https://source.chromium.org/chromium/chromium/src/+/main:ui/gl/swap_chain_presenter.cc;l=1375?q=SetColorSpace1&ss=chromium Current implementation is not wrong. chromium does nothing on the error. Somehow, I misread "SUCCEEDED" as "FAILED" :( On Firefox, it might be better to disable video overlay with the SetColorSpace1() error.