(In reply to Tomer Yavor from comment #0) > In mozila-central we have e.g., the test paths `testing/profiles/xpcshell/` or `browser/components/about/test/unit/` which are not included in the list (note `**/test*/unit*/**/` != `**/test*/unit*/`). `testing/profiles/xpcshell/` is not folder that contains xpcshell test files - it is only for the profile files that xpcshell tests use in their tests. As they are profile related, we don't need to apply the specific xpcshell test rules there. > `browser/components/about/test/unit/` which are not included in the list (note `**/test*/unit*/**/` != `**/test*/unit*/`). I think that the existing `**/test*/unit*/**/` does match `browser/components/about/test/unit/`. My understanding is that `**` will match 0 or more characters and span across directories. Additionally If I comment out that line from the top-level .eslintrc.js file, then `browser/components/about/test/unit/test_getURIFlags.js` fails due to missing symbols. > That's seems incomplete, we should consider a update (comment why we exclude paths or additional paths). We do have documentation in the source docs: https://firefox-source-docs.mozilla.org/code-quality/lint/linters/eslint.html#i-m-adding-tests-how-do-i-set-up-the-right-configuration Though I do agree that it would be good to add a comment in the file as well.
Bug 1780020 Comment 1 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
(In reply to Tomer Yavor from comment #0) > In mozila-central we have e.g., the test paths `testing/profiles/xpcshell/` or `browser/components/about/test/unit/` which are not included in the list (note `**/test*/unit*/**/` != `**/test*/unit*/`). `testing/profiles/xpcshell/` is not a folder that contains xpcshell test files - it is only for the profile files that xpcshell tests use in their tests. As they are profile related, we don't need to apply the specific xpcshell test rules there. > `browser/components/about/test/unit/` which are not included in the list (note `**/test*/unit*/**/` != `**/test*/unit*/`). I think that the existing `**/test*/unit*/**/` does match `browser/components/about/test/unit/`. My understanding is that `**` will match 0 or more characters and span across directories. Additionally If I comment out that line from the top-level .eslintrc.js file, then `browser/components/about/test/unit/test_getURIFlags.js` fails due to missing symbols. > That's seems incomplete, we should consider a update (comment why we exclude paths or additional paths). We do have documentation in the source docs: https://firefox-source-docs.mozilla.org/code-quality/lint/linters/eslint.html#i-m-adding-tests-how-do-i-set-up-the-right-configuration Though I do agree that it would be good to add a comment in the file as well.