Bug 1781086 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Revision 1 by
on 
Similar to how we do special handling for dismiss events in the Spotlight modal [here](https://searchfox.org/mozilla-central/source/browser/components/newtab/lib/Spotlight.jsm#91), handle dismiss telemetry in FeatureCallout.mjs. This should cover calls to `window.AWFinish` as well as dismiss via the ESC key.

When adding tests for this capability, also test that the correct 'page' is reported in the telemetry event context as added by bug 1779430.
Revision 3 by
on 
Similar to how we do special handling for dismiss events in the Spotlight modal [here](https://searchfox.org/mozilla-central/source/browser/components/newtab/lib/Spotlight.jsm#91), handle dismiss telemetry in FeatureCallout.mjs. This should cover calls to `window.AWFinish`, including clicks on dismiss and the final primary CTA.

When adding tests for this capability, also test that the correct 'page' is reported in the telemetry event context as added by bug 1779430.
Revision 4 by
on 
Similar to how we do special handling for dismiss events in the Spotlight modal [here](https://searchfox.org/mozilla-central/source/browser/components/newtab/lib/Spotlight.jsm#91), handle dismiss telemetry in FeatureCallout.mjs. This should cover calls to `window.AWFinish`, including clicks on dismiss and the final primary CTA.

When adding tests for this capability, also test that the correct 'page' is reported in the telemetry event context as added by bug 1779430.

Additionally, the dismiss button needs to close the callout (currently it advances it to the next slide).
Revision 5 by
on 
Clicking Feature Callout dismiss button should set the feature callout pref to show the tour as complete and record the last viewed screen.

Back to Bug 1781086 Comment 0