Bug 1781936 Comment 9 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Emilio, I was able to verified on GeckoView example app and Fenix, that your patch address the issue! 


> It should be easy to confirm whether it's the culprit? The patch should pretty much revert cleanly-ish, and is very small.


Unfortunately, when I try to run `./mach boostrap`  on your [patch](https://hg.mozilla.org/integration/autoland/rev/abfde00b332239db55492652c6e72b17404ac050) or any commit on that [commit range](https://hg.mozilla.org/integration/autoland/pushloghtml?tochange=05337140272cc5fe59e58b9d302fb84eda9acbf3&fromchange=7bc2dd06085f53993037b4fc78ee651c5afc7671) I the following error. For that reason I couldn't verify by running it.  


```
The details of the failure are as follows:

NotImplementedError: Cannot bootstrap GeckoView/Firefox for Android: mozboot.base does not yet implement install_mobile_android_packages()

  File "/Users/arturomejia/Desktop/gecko/python/mozboot/mozboot/mach_commands.py", line 50, in bootstrap
    bootstrapper.bootstrap()
  File "/Users/arturomejia/Desktop/gecko/python/mozboot/mozboot/bootstrap.py", line 447, in bootstrap
    getattr(self.instance, "install_%s_packages" % application)(mozconfig_builder)
  File "/Users/arturomejia/Desktop/gecko/python/mozboot/mozboot/base.py", line 244, in install_mobile_android_packages
    raise NotImplementedError(
```
Thanks for the patch Emilio. I was able to verified on GeckoView example app and Fenix, that your patch address the issue! 


> It should be easy to confirm whether it's the culprit? The patch should pretty much revert cleanly-ish, and is very small.


Unfortunately, when I try to run `./mach boostrap`  on your [patch](https://hg.mozilla.org/integration/autoland/rev/abfde00b332239db55492652c6e72b17404ac050) or any commit on that [commit range](https://hg.mozilla.org/integration/autoland/pushloghtml?tochange=05337140272cc5fe59e58b9d302fb84eda9acbf3&fromchange=7bc2dd06085f53993037b4fc78ee651c5afc7671) I the following error. For that reason I couldn't verify by running it.  


```
The details of the failure are as follows:

NotImplementedError: Cannot bootstrap GeckoView/Firefox for Android: mozboot.base does not yet implement install_mobile_android_packages()

  File "/Users/arturomejia/Desktop/gecko/python/mozboot/mozboot/mach_commands.py", line 50, in bootstrap
    bootstrapper.bootstrap()
  File "/Users/arturomejia/Desktop/gecko/python/mozboot/mozboot/bootstrap.py", line 447, in bootstrap
    getattr(self.instance, "install_%s_packages" % application)(mozconfig_builder)
  File "/Users/arturomejia/Desktop/gecko/python/mozboot/mozboot/base.py", line 244, in install_mobile_android_packages
    raise NotImplementedError(
```

Back to Bug 1781936 Comment 9