Bug 1787945 Comment 10 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Sam has brought up some concerns with the sizing of the X icon we've used for the dismiss button:
"The "X" icon in the recently-closed tabs dismiss button ended up being an odd size at 8px. Not too long ago we want to some effort to try and consolidate our many icons and standardize on 16 as the normal/default size, 20 for larger icons and 12 for small icons and badges. Our tab close button is 16x16.. it seem like this one should be as well?"
Can you let me know what you think, Josh? And Jane, could you please make sure we’re documenting these components as requested by Aaron Benson? Thanks, all!
Sam has brought up some concerns with the sizing of the X icon we've used for the dismiss button:
"However, 8px icons aren't really a thing we've ever done before. When we did a round of icon consolidation recently, we agreed to 3 sizes: normal/default is on a 16x16 grid ({name}.svg), , large is 20x20 ({name-20}.svg), small is 12x12 ({name}-12.svg). There are a couple of oddball exceptions, but I don't see a strong reason for this to be one. This is a variation of the close.svg, in toolkit/themes/shared/icons/close.svg, and available at chrome://global/skin/icons/close.svg. The tab close button uses this default size close.svg, do you think we could use that here as well?"
Can you let me know what you think, Josh? And Jane, could you please make sure we’re documenting these components as requested by Aaron Benson? Thanks, all!

Back to Bug 1787945 Comment 10