I'm fixing some searchfox JS indexing logic and trying to make it so we can have actionable warning report and ran into sessionstore_valid.js and sessionstore_invalid.js as sources of warnings. It seems like our root [.eslintignore](https://searchfox.org/mozilla-central/rev/5dd1f5147d3ffffb0dbd1c8cc9262887bec58014/.eslintignore#34-36) already knows about them: ``` # Test files that are really json not js, and don't need to be linted. browser/components/sessionstore/test/unit/data/sessionstore_valid.js browser/components/sessionstore/test/unit/data/sessionstore_invalid.js ``` I have some other in-flight work that will ideally let searchfox eventually know not to care about .eslintignore files, but it would be great to fix this issue as in the interim I'm putting a downgrade heuristic in place that will probably hit most of sessionstore while the workaround is present.
Bug 1792369 Comment 0 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
I'm fixing some searchfox JS indexing logic and trying to make it so we can have actionable warning reports for JS and ran into sessionstore_valid.js and sessionstore_invalid.js as sources of warnings. It seems like our root [.eslintignore](https://searchfox.org/mozilla-central/rev/5dd1f5147d3ffffb0dbd1c8cc9262887bec58014/.eslintignore#34-36) already knows about them: ``` # Test files that are really json not js, and don't need to be linted. browser/components/sessionstore/test/unit/data/sessionstore_valid.js browser/components/sessionstore/test/unit/data/sessionstore_invalid.js ``` I have some other in-flight work that will ideally let searchfox eventually know not to care about .eslintignore files, but it would be great to fix this issue as in the interim I'm putting a downgrade heuristic in place that will probably hit most of sessionstore while the workaround is present.
I'm fixing some searchfox JS indexing logic and trying to make it so we can have actionable warning reports for JS and ran into sessionstore_valid.js and sessionstore_invalid.js as sources of warnings. It seems like our root [.eslintignore](https://searchfox.org/mozilla-central/rev/5dd1f5147d3ffffb0dbd1c8cc9262887bec58014/.eslintignore#34-36) already knows about them: ``` # Test files that are really json not js, and don't need to be linted. browser/components/sessionstore/test/unit/data/sessionstore_valid.js browser/components/sessionstore/test/unit/data/sessionstore_invalid.js ``` I have some other in-flight work that will ideally let searchfox eventually know not to care about .eslintignore-listed files, but it would be great to fix this issue as in the interim I'm putting a downgrade heuristic in place that will probably hit most of sessionstore while the workaround is present.