Bug 1799264 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

I'd like to refactor individual features of quick suggest into their own classes and files. That will make it easier to individually toggle them on and off depending on their Nimbus variables and prefs. It's also good for encapsulation.
I'd like to refactor individual features of quick suggest into their own classes and files. That will make it easier to individually toggle them on and off depending on their Nimbus variables and prefs. It's also good for encapsulation.

My motivation for this is that I started adding the new weather feature to QuickSuggest and found that I was duplicating similar patterns I used with impression caps, blocked suggestions, and even remote settings. Each of these features requires some initialization when their Nimbus variables or prefs are enabled. Some also require uninitialization. The weather feature will need both. Any of these features can be enabled or disabled at any time since they depend on either Nimbus experiments or prefs that the user can toggle. It would be nice if there were a simple way to plug them into QuickSuggest and have QuickSuggest take care of enabling and disabling them appropriately.

Back to Bug 1799264 Comment 0