Bug 1801057 Comment 2 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Sure. First I'd suggest to fix this in small pieces, possibly one changeset per each source+test pair.
For example changing Bookmarks.sys.mjs, and then running the tests and modify the affected ones. This is one changeset.
In a separate changeset do PlacesDBUtils.sys.mjs, and similarly any affected tests.
And so on. By splitting into small parts we can do this incrementally and land parts that are ready.

All the references can be found here:
https://searchfox.org/mozilla-central/search?q=moz_items_anno
https://searchfox.org/mozilla-central/search?q=sync%252Fparent

The scope here is to remove any code that is managing entries in the moz_items_annos table, because we don't use those anymore, though there are a few exceptions:
* the code in Database.cpp, nsPlacesTables.h, nsPlacesIndexes.h should remain for now, because we must take care of downgrade paths, so we'll handle it apart
* some code related to the "mobile root" may be complicate to remove

Overall I'd concentrate on: Bookmarks.sys.mjs, PlacesDBUtils.sys.mjs, PlacesSyncUtils.sys.mjs, PlacesSyncUtils.sys.mjs, store.rs
Most tests can be executed using `./mach test toolkit/components/places`
For all the changes you can use an artifact build, that is quite fast.

There's documentation on how to build Firefox in https://firefox-source-docs.mozilla.org/setup/index.html
Sure. First I'd suggest to fix this in small pieces, possibly one changeset per each source+test pair.
For example changing Bookmarks.sys.mjs, and then running the tests and modify the affected ones. This is one changeset.
In a separate changeset do PlacesDBUtils.sys.mjs, and similarly any affected tests.
And so on. By splitting into small parts we can do this incrementally and land parts that are ready.

All the references can be found here:
https://searchfox.org/mozilla-central/search?q=moz_items_anno
https://searchfox.org/mozilla-central/search?q=sync%252Fparent

The scope here is to remove any code that is managing entries in the moz_items_annos table, because we don't use those anymore, though there are a few exceptions:
* the code in Database.cpp, nsPlacesTables.h, nsPlacesIndexes.h should remain for now, because we must take care of downgrade paths, so we'll handle it apart
* some code related to the "mobile root" may be complicate to remove

Overall I'd concentrate on: Bookmarks.sys.mjs, PlacesDBUtils.sys.mjs, PlacesSyncUtils.sys.mjs, PlacesSyncUtils.sys.mjs, store.rs
Most tests can be executed using `./mach xpcshell-test toolkit/components/places`
For all the changes you can use an artifact build, that is quite fast.

There's documentation on how to build Firefox in https://firefox-source-docs.mozilla.org/setup/index.html
Sure. First I'd suggest to fix this in small pieces, possibly one changeset per each source+test pair.
For example changing Bookmarks.sys.mjs, and then running the tests and modify the affected ones. This is one changeset.
In a separate changeset do PlacesDBUtils.sys.mjs, and similarly any affected tests.
And so on. By splitting into small parts we can do this incrementally and land parts that are ready.

All the references can be found here:
https://searchfox.org/mozilla-central/search?q=moz_items_anno
https://searchfox.org/mozilla-central/search?q=sync%252Fparent

The scope here is to remove any code that is managing entries in the moz_items_annos table, because we don't use those anymore, though there are a few exceptions:
* the code in Database.cpp, nsPlacesTables.h, nsPlacesIndexes.h should remain for now, because we must take care of downgrade paths, so we'll handle it apart
* some code related to the "mobile root" may be complicate to remove

Overall I'd concentrate on: Bookmarks.sys.mjs, PlacesDBUtils.sys.mjs, PlacesSyncUtils.sys.mjs, store.rs
Most tests can be executed using `./mach xpcshell-test toolkit/components/places`
For all the changes you can use an artifact build, that is quite fast.

There's documentation on how to build Firefox in https://firefox-source-docs.mozilla.org/setup/index.html

Back to Bug 1801057 Comment 2