Bugzilla

(In reply to dev from comment #15)
> Hello @kpanenio. I wanted to submit the patch. I have set up Phabricator and Moz-Phab successfully but I have an issue with how am supposed to do the commit message. Do I do a normal `git add` & `git-commit` then run this command `moz-phab [start_rev] [end_rev]` or how exactly do I do it. Thank you

(In reply to dev from comment #16)
> Because the instrusctions on the repo tells me to run `git commit`/` hg commit` so am wondering if I should skip the `git add` command and also, won't it bring an issue if I pushed without doing a pull first. Thank you

Hi Denis, it sounds like you're using git for your setup. I don't use git for Firefox development, but I believe you need `git add` to stage your changes for the next commit you make via the `git commit` command. As for `moz-phab`, you only need to run `moz-phab submit` after making your commit. And yes, it's normally a good idea to run `git pull` (or the mercurial equivalent `hg pull`) from mozilla-central to keep up with the latest version. For future questions concerning version control and moz-phab, I recommend posting your questions on the Introductions channel I mentioned earlier (if you haven't done so already). People in this channel will be able to help you faster and may even know more about git for Firefox than I do. (Plus, due to time zones differences, I unfortunately won't be able to respond right away). I will be able to guide you on steps specific to the bug itself though.

(In reply to dev from comment #15)
> Hello @kpanenio. I wanted to submit the patch. I have set up Phabricator and Moz-Phab successfully but I have an issue with how am supposed to do the commit message. Do I do a normal `git add` & `git-commit` then run this command `moz-phab [start_rev] [end_rev]` or how exactly do I do it. Thank you

(In reply to dev from comment #16)
> Because the instrusctions on the repo tells me to run `git commit`/` hg commit` so am wondering if I should skip the `git add` command and also, won't it bring an issue if I pushed without doing a pull first. Thank you

Hi Denis, it sounds like you're using git for your setup. I don't use git for Firefox development, but I believe you need `git add` to stage your changes for the next commit you make via the `git commit` command. As for `moz-phab`, you only need to run `moz-phab submit` after making your commit. And yes, it's normally a good idea to run `git pull` (or the mercurial equivalent `hg pull`) from mozilla-central to keep up with the latest version.

For future questions concerning version control and moz-phab, I recommend posting your questions on the Introductions channel I mentioned earlier (if you haven't done so already). People in this channel will be able to help you faster and may even know more about git for Firefox than I do. (Plus, due to time zones differences, I unfortunately won't be able to respond right away). I will be able to guide you on steps specific to the bug itself though.