(In reply to Mayank Bansal from comment #12) > (In reply to Jan de Mooij [:jandem] from comment #10) > > Mayank, can you confirm this is fixed in the latest Nightly? > > Profile with latest nightly : https://share.firefox.dev/3EmVd5k (https://hg.mozilla.org/mozilla-central/rev/738c0a460acb30ab2ab419f4c0dc93fa9af200d6) > This shows no improvement for some strange reason. However, earlier today I had downloaded a opt build built from the link in comment #8, and that had showed 16 seconds. Not sure whats the reason why Nightly doesnt show the perf improvement. > > I will retest in a couple of days when i have my regular laptop charger. I have no idea what I was thinking when I wrote this comment :| . I have some jetlag... The profile in this comment is 32.9 seconds long, and the OP profile took 84 seconds. . So we are already faster than Chrome which took 34 seconds on my machine. This bug improved the testcase from 84 seconds -> 33 seconds which is a massive 2.5x improvement. This bug is quit effectively fixed. Thanks :jandem for the fix!
Bug 1850305 Comment 15 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
(In reply to Mayank Bansal from comment #12) > (In reply to Jan de Mooij [:jandem] from comment #10) > > Mayank, can you confirm this is fixed in the latest Nightly? > > Profile with latest nightly : https://share.firefox.dev/3EmVd5k (https://hg.mozilla.org/mozilla-central/rev/738c0a460acb30ab2ab419f4c0dc93fa9af200d6) > This shows no improvement for some strange reason. However, earlier today I had downloaded a opt build built from the link in comment #8, and that had showed 16 seconds. Not sure whats the reason why Nightly doesnt show the perf improvement. > > I will retest in a couple of days when i have my regular laptop charger. I have no idea what I was thinking when I wrote this comment :| . I have some jetlag... The profile in this comment is 32.9 seconds long, and the OP profile took 84 seconds. . So we are already faster than Chrome which took 34 seconds on my machine. This bug improved the original testcase from 84 seconds -> 33 seconds which is a massive 2.5x improvement. This bug is quit effectively fixed. Thanks :jandem for the fix!
(In reply to Mayank Bansal from comment #12) > (In reply to Jan de Mooij [:jandem] from comment #10) > > Mayank, can you confirm this is fixed in the latest Nightly? > > Profile with latest nightly : https://share.firefox.dev/3EmVd5k (https://hg.mozilla.org/mozilla-central/rev/738c0a460acb30ab2ab419f4c0dc93fa9af200d6) > This shows no improvement for some strange reason. However, earlier today I had downloaded a opt build built from the link in comment #8, and that had showed 16 seconds. Not sure whats the reason why Nightly doesnt show the perf improvement. > > I will retest in a couple of days when i have my regular laptop charger. I have no idea what I was thinking when I wrote this comment :| . I have some jetlag... The profile in this comment is 32.9 seconds long. . So we are already faster than Chrome which took 34 seconds on my machine. This bug improved the original testcase from 84 seconds -> 33 seconds which is a massive 2.5x improvement. This bug is quit effectively fixed. Thanks :jandem for the fix!
(In reply to Mayank Bansal from comment #12) > (In reply to Jan de Mooij [:jandem] from comment #10) > > Mayank, can you confirm this is fixed in the latest Nightly? > > Profile with latest nightly : https://share.firefox.dev/3EmVd5k (https://hg.mozilla.org/mozilla-central/rev/738c0a460acb30ab2ab419f4c0dc93fa9af200d6) > This shows no improvement for some strange reason. However, earlier today I had downloaded a opt build built from the link in comment #8, and that had showed 16 seconds. Not sure whats the reason why Nightly doesnt show the perf improvement. > > I will retest in a couple of days when i have my regular laptop charger. I have no idea what I was thinking when I wrote this comment :| . I have some jetlag... The profile in this comment is 32.9 seconds long. . So we are already faster than Chrome which took 34 seconds on my machine. This bug improved the original testcase from 84 seconds -> 33 seconds which is a massive 2.5x improvement. This bug is quite effectively fixed. Thanks :jandem for the fix!