Bug 1856452 Comment 1 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Copying over my comments from the other bug:

(In reply to Markus Stange [:mstange] from bug 1856296 comment #11)
> We implement window dragging by setting up our NSView hierarchy in such a way that the NSViews in the back return `YES` from `movableByWindowBackground`, and then we place non-movable transparent NSViews in the non-movable regions of the window (they return `NO` from `movableByWindowBackground`). See [here](https://searchfox.org/mozilla-central/rev/95787423bc1c7ba895ef9c6918feb054866d9f41/widget/cocoa/nsChildView.mm#2369-2375) for more details.
> 
> We also have a hack [here](https://searchfox.org/mozilla-central/rev/95787423bc1c7ba895ef9c6918feb054866d9f41/widget/cocoa/nsChildView.mm#1917-1932) to avoid paints which might be causing problems and which might be unnecessary these days.

(In reply to Markus Stange [:mstange] bug 1856296 from comment #12)
> When debugging this, I suggest the following approach: First, try to remove the call to `ManipulateViewWithoutNeedingDisplay` (just call `mNonDraggableRegion.UpdateRegion` directly). If that doesn't fix it, dump the NSView hierarchy starting at the window's border view (`[[window contentView] superview]`) along with each view's `movableByWindowBackground` property. There may also be a `NSWindow` styleMask flag that affects this behavior.
Copying over my comments from the other bug:

(In reply to Markus Stange [:mstange] from bug 1856296 comment #11)
> We implement window dragging by setting up our NSView hierarchy in such a way that the NSViews in the back return `YES` from `movableByWindowBackground`, and then we place non-movable transparent NSViews in the non-movable regions of the window (they return `NO` from `movableByWindowBackground`). See [here](https://searchfox.org/mozilla-central/rev/95787423bc1c7ba895ef9c6918feb054866d9f41/widget/cocoa/nsChildView.mm#2369-2375) for more details.
> 
> We also have a hack [here](https://searchfox.org/mozilla-central/rev/95787423bc1c7ba895ef9c6918feb054866d9f41/widget/cocoa/nsChildView.mm#1917-1932) to avoid paints which might be causing problems and which might be unnecessary these days.

(In reply to Markus Stange [:mstange] from bug 1856296 comment #12)
> When debugging this, I suggest the following approach: First, try to remove the call to `ManipulateViewWithoutNeedingDisplay` (just call `mNonDraggableRegion.UpdateRegion` directly). If that doesn't fix it, dump the NSView hierarchy starting at the window's border view (`[[window contentView] superview]`) along with each view's `movableByWindowBackground` property. There may also be a `NSWindow` styleMask flag that affects this behavior.

Back to Bug 1856452 Comment 1