Bug 1879975 Comment 8 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

This should be fixed in FX126 now, assuming my code changes don't get reverted for any reason.
With my changes, pinning works now sometimes on the newest beta channel of Windows.

Sometimes, it still does not work. It appears that trying to pin too many times, or pinning too quickly on start up of Firefox results in pinning failing and no error reported to the user. On one occasion, pinning from Firefox would not work again until I restarted my computer.

To trigger pinning, go to about:welcome, ensure that "Pin _____ to taskbar" is checked, and hit the "Save and Continue" button.

To test these new changes, a couple of scenarios have to be verified as working.

1) Confirm that pinning continues to work on older versions of Windows. To verify, attempt to pin through about:welcome with Firefox 125 and if that works, run FX 126 and confirm that pinning still works.

2) Confirm that pinning works on newer versions of Windows. Right now, that is probably just the beta or developer / canary builds of Windows. If running those, confirm you're on a version that blocks the old pinning mechanism. Run FX 125 and attempt to pin by about:welcome. If pinning fails, you are on a version of Windows that blocks the old mechanism. Now run FX 126 and confirm that pinning from about:welcome does work. It should pop up a system confirmation box in the bottom right. See the attached image.

Since this wasn't working for me occasionally, testing on different machines, and pinning quickly after startup or waiting, and doing it many times, would be helpful to narrow down how often it breaks for others.
This should be fixed in FX126 now, assuming my code changes don't get reverted for any reason.
With my changes, pinning works now sometimes on the newest beta channel of Windows. Note that private-browsing can't be pinned and no other pins work unless done manually by the user right clicking on an icon in the taskbar and choosing to pin it.

Sometimes, pinning still does not work. It appears that trying to pin too many times, or pinning too quickly on start up of Firefox results in pinning failing and no error reported to the user. On one occasion, pinning from Firefox would not work again until I restarted my computer.

To trigger pinning, go to about:welcome, ensure that "Pin _____ to taskbar" is checked, and hit the "Save and Continue" button.

To test these new changes, a couple of scenarios have to be verified as working.

1) Confirm that pinning continues to work on older versions of Windows. To verify, attempt to pin through about:welcome with Firefox 125 and if that works, run FX 126 and confirm that pinning still works.

2) Confirm that pinning works on newer versions of Windows. Right now, that is probably just the beta or developer / canary builds of Windows. If running those, confirm you're on a version that blocks the old pinning mechanism. Run FX 125 and attempt to pin by about:welcome. If pinning fails, you are on a version of Windows that blocks the old mechanism. Now run FX 126 and confirm that pinning from about:welcome does work. It should pop up a system confirmation box in the bottom right. See the attached image.

Since this wasn't working for me occasionally, testing on different machines, and pinning quickly after startup or waiting, and doing it many times, would be helpful to narrow down how often it breaks for others.

Back to Bug 1879975 Comment 8