Bugzilla

I’ve been working on bug 406629 where we want to apply a `max-width` to the sidebar that equates to 75% of the viewport. We want to apply that to the existing sidebar as well as the new one that’s behind the pref `sidebar.revamp` . For the new sidebar, we’re having to take into account the width of a vertical menu with buttons for tools, tabs, extensions, etc. which can be collapsed by default or expanded to show icons and text.
I noticed some weirdness with the icon alignment in the button in my patch after I expand the left sidebar menu, then collapse back down and every time I’d attempt to inspect it, it would crash the browser:

See a screen recording of this [here](https://drive.google.com/file/d/1DG4EHVj9KeiNNYH6R39p5uTFF7DKFDtY/view?usp=sharing).

I’ve found a workaround for it for now, but it was reproducible in [this diff](https://hg.mozilla.org/try/rev/f9d35c4e25781cfd6c2d05c507d5a1983d36e1a5). I’m thinking it may have to do with the fact that I was using floating numbers for the values of the expanded/collapsed vertical sidebar menu, as the issue doesn't seem to happen if I change those to whole numbers.

I’ve been working on bug 406629 where we want to apply a `max-width` to the sidebar that equates to 75% of the viewport. We want to apply that to the existing sidebar as well as the new one that’s behind the pref `sidebar.revamp` . For the new sidebar, we’re having to take into account the width of a vertical menu with buttons for tools, tabs, extensions, etc. which can be collapsed by default or expanded to show icons and text.
I noticed some weirdness with the icon alignment in the button in my patch after I expand the left sidebar menu, then collapse back down and every time I’d attempt to inspect it, it would crash the browser:

See a screen recording of this [here](https://drive.google.com/file/d/1DG4EHVj9KeiNNYH6R39p5uTFF7DKFDtY/view?usp=sharing).

I’ve found a workaround for it for now, but it was reproducible in [this diff](https://phabricator.services.mozilla.com/D211440?id=872718). I’m thinking it may have to do with the fact that I was using floating numbers for the values of the expanded/collapsed vertical sidebar menu, as the issue doesn't seem to happen if I change those to whole numbers.

I’ve been working on bug 406629 where we want to apply a `max-width` to the sidebar that equates to 75% of the viewport. We want to apply that to the existing sidebar as well as the new one that’s behind the pref `sidebar.revamp` . For the new sidebar, we’re having to take into account the width of a vertical menu with buttons for tools, tabs, extensions, etc. which can be collapsed by default or expanded to show icons and text.
I noticed some weirdness with the icon alignment in the button in my patch after I expand the left sidebar menu, then collapse back down and every time I’d attempt to inspect it, it would crash the browser:

See a screen recording of this [here](https://drive.google.com/file/d/1DG4EHVj9KeiNNYH6R39p5uTFF7DKFDtY/view?usp=sharing).

I’ve found a workaround for it for now, but it was reproducible in [this diff](https://phabricator.services.mozilla.com/D211440?id=872718). I’m thinking it may have to do with the fact that I was using floating numbers for the values of the expanded/collapsed vertical sidebar menu, as the issue doesn't seem to happen if I change those to whole numbers.

STR:
Apply changes from this diff [this diff](https://phabricator.services.mozilla.com/D211440?id=872718).
Switch the `sidebar.revamp` pref to true in about:config and restart the browser.
Toggle the new sidebar to expand it and collapse it using the sidebar button (next to refresh in the nav bar).
Notice the icon for the "Tabs from other devices" button in the sidebar is now no longer horizontally centered.
Use browser toolbox to attempt to inspect that button, but notice that the browser crashes as you hover over the `#sidebar-main` element.