Bugzilla

(In reply to Alessandro Castellani (:aleca) from comment #177)
> Created attachment 9113386 [details] [diff] [review]
> 440377-ui-solution2.patch
> Here's also a try run, let's see how this one goes: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=0c8944c58d1c7f43fbd6299ae93dec5f66ff6805

So I've finally had a chance to test this out for the first time (looking at UI-2).
Impressive it is, a fine work, and hard labor; thanks a lot Alessandro! :-)

As a general caveat, I believe that we should not underestimate the impact of this change to existing users who have developed their workflows in the current "vertical" recipient UI since time immemorial. Which should be an impetus to be as convincing as possible with a fine-tuned, flawless, maximally convenient, and value-added UX.

Here's some remarks/issues of my first-impression ui-review (with a special focus on keyboard operation)...

1. Pls implement Shift+Movement keys for selecting multiple consecutive pills
2. Pls remove Ctrl+Movement keys for selecting multiple consecutive pills, and allow selection of non-consecutive pills instead. Pls try keyboard selection methods in windows explorer; let's be consistent! For Ctrl+Movement keys, the current selection must be preserved, and we need a focus ring (only!) when moving to the next pill, which can then be selected (and de-selected) with Space bar.
3. Pls distinguish the effects of hover vs. select. See windows explorer. Otherwise Ctrl+Left-click to select becomes a guessing game.
4. Hand cursor? Is it a link?
5. Per my comment 117, I still feel that: Double-click is non-standard and undiscoverable to edit the label of an object. Typically, single-click selects, another single-click edits, and double-click opens. Compare e.g. the behaviour of file name labels in Windows Explorer ;-)
6. For windows users, pls implement F2 to edit the label (which is the Windows default shortcut for editing texty things, cf. renaming files, editing Excel cells, etc.)
7. Behaviour inconsistency:
- Type foo@bar.com, press Enter -> get cursor to continue (correct). vs.
- Cursor onto existing pill {foo@bar.com}, press Enter to edit, Re-Type, press Enter -> still stuck on the pill. This should return the cursor to continue, just as it did for the first round of typing.
8. Pressing Backspace or DEL on an empty pill in edit mode should remove the pill and just show cursor, similar to the current behaviour when pressing DEL or Backspace on an empty row (consider recipient rows a vertical precursory version of pills) - possible with event.repeat, see patch of Bug 1527547.
9. Cursoring onto a single pill pretends to select it, but doesn't. Please do select. Just like... drumroll... Windows Explorer. We really want to use Ctrl+X and Ctrl+C on that single pill.
10. Please allow me to enter |Johnson, Peter| even when I already have |Johnson, Jane| in my address book. Current: comma after a name which has a (single?) partial autocomplete match will create the pill prematurely: {Johnson}
11. Do we need a permanent delete button on CC and BCC rows? I think it's enough to show the delete button when the row (or the CC label) is hovered or focused. We've just de-cluttered the recipient area, and the general trend in UX is hiding what's not immediately needed in the given context.
12. Thou shalt not kill:
- have a couple of pills
- start typing another one:
{pill-1} {pill-2} ... {pill-N} John D|
- notice that you want Jane Doe instead, hold Backspace to correct what you just typed...

  BOOM! All pills gone. :-(( Please don't. Backspace must break/stop after deleting the unfinished pill. Only after releasing the key, that's when we want to start deleting other pills. Use event.repeat as above in my point 8, see patch of Bug 1527547.

So much for now. It's a lot of work. Again, much appreciated! :-)

(In reply to Alessandro Castellani (:aleca) from comment #177)
> Created attachment 9113386 [details] [diff] [review]
> 440377-ui-solution2.patch
> Here's also a try run, let's see how this one goes: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=0c8944c58d1c7f43fbd6299ae93dec5f66ff6805

So I've finally had a chance to test this out for the first time (looking at UI-2).
Impressive it is, a fine work, and hard labor; thanks a lot Alessandro! :-)

As a general caveat, I believe that we should not underestimate the impact of this change to existing users who have developed their workflows in the current "vertical" recipient UI since time immemorial. Which should be an impetus to be as convincing as possible with a fine-tuned, flawless, maximally convenient, and value-added UX.

Here's some remarks/issues of my first-impression ui-review (with a special focus on keyboard operation)...

1. Pls implement Shift+Movement keys for selecting multiple consecutive pills
2. Pls remove Ctrl+Movement keys for selecting multiple consecutive pills, and allow selection of non-consecutive pills instead. Pls try keyboard selection methods in windows explorer; let's be consistent! For Ctrl+Movement keys, the current selection must be preserved, and we need a focus ring (only!) when moving to the next pill, which can then be selected (and de-selected) with Space bar.
3. Pls distinguish the effects of hover vs. select. See windows explorer. Otherwise Ctrl+Left-click to select becomes a guessing game.
4. Hand cursor? Is it a link?
5. Per my comment 117, I still feel that: Double-click is non-standard and undiscoverable to edit the label of an object. Typically, single-click selects, another single-click edits, and double-click opens. Compare e.g. the behaviour of file name labels in Windows Explorer ;-)
6. For windows users, pls implement F2 to edit the label (which is the Windows default shortcut for editing texty things, cf. renaming files, editing Excel cells, etc.)
7. Behaviour inconsistency:
- Type foo@bar.com, press Enter -> get cursor to continue (correct). vs.
- Cursor onto existing pill {foo@bar.com}, press Enter to edit, Re-Type, press Enter -> still stuck on the pill. This should return the cursor to continue, just as it did for the first round of typing.
8. Pressing Backspace or DEL on an empty pill in edit mode should remove the pill and just show cursor, similar to the current behaviour when pressing DEL or Backspace on an empty row (consider recipient rows a vertical precursory version of pills) - possible with event.repeat, see patch of Bug 1527547.
9. Cursoring onto a single pill pretends to select it, but doesn't. Please do select. Just like... drumroll... Windows Explorer. We really want to use Ctrl+X and Ctrl+C on that single pill.
10. Please allow me to enter |Johnson, Peter| even when I already have |Johnson, Jane| in my address book. Current: comma after a name which has a (single?) partial autocomplete match will create the pill prematurely: {Johnson}
11. Do we need a permanent delete button on CC and BCC rows? I think it's enough to show the delete button when the row (or the CC label) is hovered or focused. We've just de-cluttered the recipient area, and the general trend in UX is hiding what's not immediately needed in the given context.
12. Thou shalt not kill:
- have a couple of pills
- start typing another one:
{pill-1} {pill-2} ... {pill-N} John D|
- notice that you want Jane Doe instead, hold Backspace to correct what you just typed...

  BOOM! All pills gone. :-(( Please don't. Backspace must break/stop after deleting the unfinished pill. Only after releasing and re-pressing the backspace key, that's when we want to start deleting other pills. Use event.repeat as above in my point 8, see patch of Bug 1527547.

So much for now. It's a lot of work. Again, much appreciated! :-)

(In reply to Alessandro Castellani (:aleca) from comment #177)
> Created attachment 9113386 [details] [diff] [review]
> 440377-ui-solution2.patch
> Here's also a try run, let's see how this one goes: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=0c8944c58d1c7f43fbd6299ae93dec5f66ff6805

So I've finally had a chance to test this out for the first time (looking at UI-2).
Impressive it is, a fine work, and hard labor; thanks a lot Alessandro! :-)

As a general caveat, I believe that we should not underestimate the impact of this change to existing users who have developed their workflows in the current "vertical" recipient UI since time immemorial. Which should be an impetus to be as convincing as possible with a fine-tuned, flawless, maximally convenient, and value-added UX.

Here's some remarks/issues of my first-impression ui-review (with a special focus on keyboard operation)...

1. Pls implement Shift+Movement keys for selecting multiple consecutive pills
2. Pls remove Ctrl+Movement keys for selecting multiple *consecutive* pills, and allow selection of *non-consecutive* pills instead. Pls try keyboard selection methods in windows explorer; let's be consistent! For Ctrl+Movement keys, the current selection must be preserved, and we need a focus ring (only!) when moving to the next pill, which can then be selected (and de-selected) with Space bar.
3. Pls distinguish the effects of hover vs. select. See windows explorer. Otherwise Ctrl+Left-click to select becomes a guessing game.
4. Hand cursor? Is it a link?
5. Per my comment 117, I still feel that: Double-click is non-standard and undiscoverable to edit the label of an object. Typically, single-click selects, another single-click edits, and double-click opens. Compare e.g. the behaviour of file name labels in Windows Explorer ;-)
6. For windows users, pls implement F2 to edit the label (which is the Windows default shortcut for editing texty things, cf. renaming files, editing Excel cells, etc.)
7. Behaviour inconsistency:
- Type foo@bar.com, press Enter -> get cursor to continue (correct). vs.
- Cursor onto existing pill {foo@bar.com}, press Enter to edit, Re-Type, press Enter -> still stuck on the pill. This should return the cursor to continue, just as it did for the first round of typing.
8. Pressing Backspace or DEL on an empty pill in edit mode should remove the pill and just show cursor, similar to the current behaviour when pressing DEL or Backspace on an empty row (consider recipient rows a vertical precursory version of pills) - possible with event.repeat, see patch of Bug 1527547.
9. Cursoring onto a single pill pretends to select it, but doesn't. Please do select. Just like... drumroll... Windows Explorer. We really want to use Ctrl+X and Ctrl+C on that single pill.
10. Please allow me to enter |Johnson, Peter| even when I already have |Johnson, Jane| in my address book. Current: comma after a name which has a (single?) partial autocomplete match will create the pill prematurely: {Johnson}
11. Do we need a permanent delete button on CC and BCC rows? I think it's enough to show the delete button when the row (or the CC label) is hovered or focused. We've just de-cluttered the recipient area, and the general trend in UX is hiding what's not immediately needed in the given context.
12. Thou shalt not kill:
- have a couple of pills
- start typing another one:
{pill-1} {pill-2} ... {pill-N} John D|
- notice that you want Jane Doe instead, hold Backspace to correct what you just typed...

  BOOM! All pills gone. :-(( Please don't. Backspace must break/stop after deleting the unfinished pill. Only after releasing and re-pressing the backspace key, that's when we want to start deleting other pills. Use event.repeat as above in my point 8, see patch of Bug 1527547.

So much for now. It's a lot of work. Again, much appreciated! :-)