Bug 480730 Comment 9 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Mike Hommey [:glandium] from comment #8)
> > I think this was an incorrect decision. The check for the file should be done at a higher level.
> 
> I disagree.

NSS attempts to load from a path that might not exist.

NSS relies on dlopen to fail if the library does not exist.

That failure is not guaranteed on macOS, because dlopen will load from a different location, if the library exists at a different location.

If NSS relies on the failure, to attempt to achieve that only a library from a known location is loaded, then NSS should not rely on dlopen on macOS, but should check by itself if the file exists, prior to attempting to loading it.

That's that the NSS change in bug 1653310 will do, which landed today.

Knowing that macOS doesn't guarantee a failure to load, I think it was wrong to hack NSPR to produce that failure.

Back to Bug 480730 Comment 9