Bug 766661 Comment 84 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Patrick Brosset <:pbro> from comment #83)
> A better solution would be to use the code that Firefox Screenshot uses as the tool does not seem subject to the same limitation.

Actually bug 1576210 and bug 1570231 seem to disagree with this. But at least the tool does not fail silently. A part of the webpage still gets turned into the image.
(In reply to Patrick Brosset <:pbro> from comment #83)
> A better solution would be to use the code that Firefox Screenshot uses as the tool does not seem subject to the same limitation.

Actually bug 1576210 and bug 1570231 seem to disagree with this. But at least the tool does not fail silently. A part of the webpage still gets turned into the image.

Firefox Screenshot does this by caping the max height and width of the image with [these values](https://searchfox.org/mozilla-central/rev/1db5ef59eba65d32d6a29a494e87b6078453e559/browser/extensions/screenshots/selector/uicontrol.js#52-53) used [here](https://searchfox.org/mozilla-central/rev/1db5ef59eba65d32d6a29a494e87b6078453e559/browser/extensions/screenshots/selector/uicontrol.js#219-220).
(In reply to Patrick Brosset <:pbro> from comment #83)
> A better solution would be to use the code that Firefox Screenshot uses as the tool does not seem subject to the same limitation.

Actually bug 1576210 and bug 1570231 seem to disagree with this. But at least the tool does not fail silently. A part of the webpage still gets turned into the image.

Firefox Screenshot does this by capping the max height and width of the image with [these values](https://searchfox.org/mozilla-central/rev/1db5ef59eba65d32d6a29a494e87b6078453e559/browser/extensions/screenshots/selector/uicontrol.js#52-53) used [here](https://searchfox.org/mozilla-central/rev/1db5ef59eba65d32d6a29a494e87b6078453e559/browser/extensions/screenshots/selector/uicontrol.js#219-220).

[This diff](https://hg.mozilla.org/mozilla-central/rev/933b30269777) shows when and how the capping was added. Note that the tool displays a warning when a full page screenshot was cut-off.

Back to Bug 766661 Comment 84