571349 unknown 2010-06-10 14:24:49 -0700 [mozmill] testDownloadManagerClosed.js doesn't correctly cleanup downloaded files 2019-07-03 12:10:43 -0700 1 1 6 Graveyard Mozilla QA Graveyard Mozmill Tests unspecified All All defect RESOLVED FIXED [mozmill-test-failure][mozmill-doc-needed] -- major --- 1 hskupin hskupin hskupin k0scist --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- 2010-06-15 08:54:45 --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- 2010-06-15 08:54:45 0 4738562 hskupin 2010-06-10 14:24:49 -0700 Looks like that the file we download during the PB mode is active doesn't get cleaned-up correctly, because we simply look into the database to collect those files to download. But during pb mode we have a temporary table. I will have to fix that. 4740979 hskupin 2010-06-11 17:32:47 -0700 Files which lingering around in my download folder are: etd_lesson2.pdf rar_expander_v084 bzip2-1.0.5.tar.gz So those are all files we download. Even the file when we are normally in Private Browsing mode! Ehsan, we really have to delete those temporarily files which have been downloaded in PB mode once we leave it, so I wonder why that doesn't happen in our test. 4740990 k0scist 2010-06-11 17:40:28 -0700 If you can set the browser.download.dir preference to some temporary directory that would probably be sufficient (not sure if this is easy/possible at this point) 4741660 450894 hskupin 2010-06-12 18:28:50 -0700 Created attachment 450894 Allow user defined download list We should simply allow the user to pass in a custom list of downloads. That way we can also make sure that the file downloaded in Private Browsing mode gets deleted. 4741661 hskupin 2010-06-12 18:33:17 -0700 (In reply to comment #2) > If you can set the browser.download.dir preference to some temporary directory > that would probably be sufficient (not sure if this is easy/possible at this > point) Kinda hard to get the temporary folder from within Javascript. Now that we correctly delete our downloaded files, it should be ok. If you still think we should use a temporary folder please create a new bug. 4745066 hskupin 2010-06-15 01:54:45 -0700 Landed on all branches: http://hg.mozilla.org/qa/mozmill-tests/rev/c1821e538c5d http://hg.mozilla.org/qa/mozmill-tests/rev/2633e5912e4a http://hg.mozilla.org/qa/mozmill-tests/rev/9fdc5f2074df 5094622 hskupin 2010-11-19 12:48:10 -0800 Mass move of Mozmill Test related project bugs to newly created components. You can filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria. 450894 2010-06-12 18:28:50 -0700 2010-06-14 17:00:29 -0700 Allow user defined download list download text/plain 4610 hskupin IyBIRyBjaGFuZ2VzZXQgcGF0Y2gKIyBQYXJlbnQgZjM5MDk0MmUzMGViMTRlN2Q2NTkyYjU0YjNl NWMyNzQzMzQwN2VhNgpCdWcgNTcxMzQ5IC0gdGVzdERvd25sb2FkTWFuYWdlckNsb3NlZC5qcyBk b2Vzbid0IGNvcnJlY3RseSBjbGVhbnVwIGRvd25sb2FkZWQgZmlsZXMsIHI9YXNodWdoZXMKCmRp ZmYgLS1naXQgYS9maXJlZm94L3Rlc3RQcml2YXRlQnJvd3NpbmcvdGVzdERvd25sb2FkTWFuYWdl ckNsb3NlZC5qcyBiL2ZpcmVmb3gvdGVzdFByaXZhdGVCcm93c2luZy90ZXN0RG93bmxvYWRNYW5h Z2VyQ2xvc2VkLmpzCi0tLSBhL2ZpcmVmb3gvdGVzdFByaXZhdGVCcm93c2luZy90ZXN0RG93bmxv YWRNYW5hZ2VyQ2xvc2VkLmpzCisrKyBiL2ZpcmVmb3gvdGVzdFByaXZhdGVCcm93c2luZy90ZXN0 RG93bmxvYWRNYW5hZ2VyQ2xvc2VkLmpzCkBAIC01Niw1MSArNTYsNTEgQEAgdmFyIHNldHVwTW9k dWxlID0gZnVuY3Rpb24obW9kdWxlKQogICBjb250cm9sbGVyID0gbW96bWlsbC5nZXRCcm93c2Vy Q29udHJvbGxlcigpOwogCiAgIC8vIE1ha2Ugc3VyZSB0aGVyZSBhcmUgbm8gYWN0aXZlIGRvd25s b2FkcywgZG93bmxvYWRlZCBmaWxlcwogICAvLyBvciBkYXRhIGluIHRoZSBEb3dubG9hZCBNYW5h Z2VyIGRhdGFiYXNlIGJlZm9yZSBiZWdpbm5pbmcKICAgZG0gPSBuZXcgRG93bmxvYWRzQVBJLmRv d25sb2FkTWFuYWdlcigpOwogICBkbS5jbGVhbkFsbCgpOwogCiAgIC8vIEFycmF5IGZvciBkb3du bG9hZGVkIGZpbGVzCi0gIGN1ckRvd25sb2FkcyA9IFtdOworICBkb3dubG9hZGVkRmlsZXMgPSBb XTsKIAogICAvLyBNYWtlIHN1cmUgd2UgYXJlIG5vdCBpbiBQQiBtb2RlIGFuZCBkb24ndCBzaG93 IGEgcHJvbXB0CiAgIHBiID0gbmV3IFByaXZhdGVCcm93c2luZ0FQSS5wcml2YXRlQnJvd3Npbmco Y29udHJvbGxlcik7CiAgIHBiLmVuYWJsZWQgPSBmYWxzZTsKICAgcGIuc2hvd1Byb21wdCA9IGZh bHNlOwogfQogCiB2YXIgdGVhcmRvd25Nb2R1bGUgPSBmdW5jdGlvbihtb2R1bGUpCiB7Ci0gIGRt LmNsZWFuQWxsKCk7CisgIGRtLmNsZWFuQWxsKGRvd25sb2FkZWRGaWxlcyk7CiAgIHBiLnJlc2V0 KCk7CiAKICAgUHJlZnNBUEkucHJlZmVyZW5jZXMuY2xlYXJVc2VyUHJlZigiYnJvd3Nlci5kb3du bG9hZC5tYW5hZ2VyLnNob3dXaGVuU3RhcnRpbmciKTsKIH0KIAogLyoqCiAgKiBUZXN0IHRoYXQg bm8gZG93bmxvYWRzIGFyZSBzaG93biB3aGVuIHN3aXRjaGluZyBpbi9vdXQgb2YgUEIgbW9kZQog ICovCiB2YXIgdGVzdERvd25sb2FkTWFuYWdlckNsb3NlZCA9IGZ1bmN0aW9uKCkKIHsKICAgLy8g RGlzYWJsZSB0aGUgb3BlbmluZyBvZiB0aGUgRG93bmxvYWRzIE1hbmFnZXIgd2hlbiBzdGFydGlu ZyBhIGRvd25sb2FkCiAgIFByZWZzQVBJLm9wZW5QcmVmZXJlbmNlc0RpYWxvZyhoYW5kbGVQcmVm RGlhbG9nKTsKIAogICAvLyBEb3dubG9hZCBhIGNvdXBsZSBvZiBmaWxlcwotICBmb3IgKHZhciBp aSA9IDA7IGlpIDwgZG93bmxvYWRzLmxlbmd0aDsgaWkrKykKLSAgICBEb3dubG9hZHNBUEkuZG93 bmxvYWRGaWxlT2ZVbmtub3duVHlwZShjb250cm9sbGVyLCBkb3dubG9hZHNbaWldKTsKKyAgZm9y IGVhY2ggKGRvd25sb2FkIGluIGRvd25sb2FkcykKKyAgICBEb3dubG9hZHNBUEkuZG93bmxvYWRG aWxlT2ZVbmtub3duVHlwZShjb250cm9sbGVyLCBkb3dubG9hZCk7CisKKyAgLy8gU2F2ZSBpbmZv cm1hdGlvbiBvZiBjdXJyZW50bHkgZG93bmxvYWRlZCBmaWxlcworICBkb3dubG9hZGVkRmlsZXMg PSBkbS5nZXRBbGxEb3dubG9hZHMoKTsKIAogICAvLyBXYWl0IHVudGlsIGFsbCBkb3dubG9hZHMg aGF2ZSBiZWVuIGZpbmlzaGVkCiAgIGNvbnRyb2xsZXIuc2xlZXAoMTAwKTsKICAgY29udHJvbGxl ci53YWl0Rm9yRXZhbCgic3ViamVjdC5hY3RpdmVEb3dubG9hZENvdW50ID09IDAiLCAzMDAwMCwg MTAwLCBkbSk7CiAKLSAgLy8gU2F2ZSBpbmZvcm1hdGlvbiBvZiBjdXJyZW50bHkgZG93bmxvYWRl ZCBmaWxlcwotICBjdXJEb3dubG9hZHMgPSBkbS5nZXRBbGxEb3dubG9hZHMoKTsKLQogICAvLyBF bmFibGUgUHJpdmF0ZSBCcm93c2luZyBtb2RlCiAgIHBiLnN0YXJ0KCk7CiAKICAgLy8gQ2hlY2sg dGhhdCBubyBkb3dubG9hZHMgYXJlIHNob3duCiAgIGRtLm9wZW4oY29udHJvbGxlcik7CiAKICAg dmFyIGRvd25sb2FkVmlldyA9IG5ldyBlbGVtZW50c2xpYi5JRChkbS5jb250cm9sbGVyLndpbmRv dy5kb2N1bWVudCwgImRvd25sb2FkVmlldyIpOwogICBkbS5jb250cm9sbGVyLndhaXRGb3JFbGVt ZW50KGRvd25sb2FkVmlldywgZ1RpbWVvdXQpOwpAQCAtMTA4LDIzICsxMDgsMjMgQEAgdmFyIHRl c3REb3dubG9hZE1hbmFnZXJDbG9zZWQgPSBmdW5jdGlvbgogICAgICAgICAgICAgICAgICAgICAg ICAgICAgIGdUaW1lb3V0LCAxMDAsIGRvd25sb2FkVmlldy5nZXROb2RlKCkpOwogCiAgIC8vIENs b3NlIHRoZSBEb3dubG9hZCBNYW5hZ2VyCiAgIGRtLmNsb3NlKCk7CiAKICAgLy8gRG93bmxvYWQg YSBmaWxlIGluIFByaXZhdGUgQnJvd3NpbmcgbW9kZQogICBEb3dubG9hZHNBUEkuZG93bmxvYWRG aWxlT2ZVbmtub3duVHlwZShjb250cm9sbGVyLCBkb3dubG9hZHNQQlswXSk7CiAKKyAgLy8gVHJh Y2sgdGhlIGRvd25sb2FkIGZyb20gUHJpdmF0ZSBCcm93c2luZyBtb2RlIHRvbworICBkb3dubG9h ZGVkRmlsZXMgPSBkb3dubG9hZGVkRmlsZXMuY29uY2F0KGRtLmdldEFsbERvd25sb2FkcygpKTsK KwogICAvLyBXYWl0IHVudGlsIGFsbCBkb3dubG9hZHMgaGF2ZSBiZWVuIGZpbmlzaGVkCiAgIGNv bnRyb2xsZXIuc2xlZXAoMTAwKTsKICAgY29udHJvbGxlci53YWl0Rm9yRXZhbCgic3ViamVjdC5h Y3RpdmVEb3dubG9hZENvdW50ID09IDAiLCAzMDAwMCwgMTAwLCBkbSk7CiAKLSAgLy8gVHJhY2sg dGhlIGRvd25sb2FkIGZyb20gUHJpdmF0ZSBCcm93c2luZyBtb2RlIHRvbwotICBjdXJEb3dubG9h ZHMgPSBjdXJEb3dubG9hZHMuY29uY2F0KGRtLmdldEFsbERvd25sb2FkcygpKTsKLQogICBwYi5z dG9wKCk7CiAKICAgLy8gQ2hlY2sgdGhhdCB0aGUgZG93bmxvYWRzIGZyb20gYmVmb3JlIHRoZSBQ cml2YXRlIEJyb3dzaW5nIG1vZGUgYXJlIHNob3duCiAgIGRtLm9wZW4oY29udHJvbGxlcik7CiAK ICAgZG93bmxvYWRWaWV3ID0gbmV3IGVsZW1lbnRzbGliLklEKGRtLmNvbnRyb2xsZXIud2luZG93 LmRvY3VtZW50LCAiZG93bmxvYWRWaWV3Iik7CiAgIGRtLmNvbnRyb2xsZXIud2FpdEZvckVsZW1l bnQoZG93bmxvYWRWaWV3LCBnVGltZW91dCk7CiAgIGRtLmNvbnRyb2xsZXIud2FpdEZvckV2YWwo InN1YmplY3QuaXRlbUNvdW50ID09ICIgKyBkb3dubG9hZHMubGVuZ3RoLApkaWZmIC0tZ2l0IGEv c2hhcmVkLW1vZHVsZXMvdGVzdERvd25sb2Fkc0FQSS5qcyBiL3NoYXJlZC1tb2R1bGVzL3Rlc3RE b3dubG9hZHNBUEkuanMKLS0tIGEvc2hhcmVkLW1vZHVsZXMvdGVzdERvd25sb2Fkc0FQSS5qcwor KysgYi9zaGFyZWQtbW9kdWxlcy90ZXN0RG93bmxvYWRzQVBJLmpzCkBAIC0xMjAsMjQgKzEyMCwz MiBAQCBkb3dubG9hZE1hbmFnZXIucHJvdG90eXBlID0gewogICBjbGVhblVwIDogZnVuY3Rpb24g ZG93bmxvYWRNYW5hZ2VyX2NsZWFuVXAoKQogICB7CiAgICAgdGhpcy5fZG1zLmNsZWFuVXAoKTsK ICAgfSwKIAogICAvKioKICAgICogQ2FuY2VsIGFueSBhY3RpdmUgZG93bmxvYWRzLCByZW1vdmUg dGhlIGZpbGVzLCBhbmQgY2xlYW4KICAgICogdXAgdGhlIERvd25sb2FkIE1hbmFnZXIgZGF0YWJh c2UKKyAgICoKKyAgICogQHBhcmFtIHtBcnJheSBvZiBkb3dubG9hZH0gZG93bmxvYWRzCisgICAq ICAgICAgICBEb3dubG9hZGVkIGZpbGVzIHdoaWNoIHNob3VsZCBiZSBkZWxldGVkIChvcHRpb25h bCkKICAgICovCi0gIGNsZWFuQWxsIDogZnVuY3Rpb24gZG93bmxvYWRNYW5hZ2VyX2NsZWFuQWxs KCkKKyAgY2xlYW5BbGwgOiBmdW5jdGlvbiBkb3dubG9hZE1hbmFnZXJfY2xlYW5BbGwoZG93bmxv YWRzKQogICB7CiAgICAgLy8gQ2FuY2VsIGFueSBhY3RpdmUgZG93bmxvYWRzCiAgICAgdGhpcy5j YW5jZWxBY3RpdmVEb3dubG9hZHMoKTsKIAorICAgIC8vIElmIG5vIGRvd25sb2FkcyBoYXZlIGJl ZW4gc3BlY2lmaWVkIHJldHJpZXZlIHRoZSBsaXN0IGZyb20gdGhlIGRhdGFiYXNlCisgICAgaWYg KGRvd25sb2FkcyA9PT0gdW5kZWZpbmVkIHx8IGRvd25sb2Fkcy5sZW5ndGggPT0gMCkKKyAgICAg IGRvd25sb2FkcyA9IHRoaXMuZ2V0QWxsRG93bmxvYWRzKCk7CisgICAgZWxzZQorICAgICAgZG93 bmxvYWRzID0gZG93bmxvYWRzLmNvbmNhdCh0aGlzLmdldEFsbERvd25sb2FkcygpKTsKKwogICAg IC8vIERlbGV0ZSBhbGwgZmlsZXMgcmVmZXJyZWQgdG8gaW4gdGhlIERvd25sb2FkIE1hbmFnZXIK LSAgICB2YXIgZG93bmxvYWRzID0gdGhpcy5nZXRBbGxEb3dubG9hZHMoKTsKICAgICB0aGlzLmRl bGV0ZURvd25sb2FkZWRGaWxlcyhkb3dubG9hZHMpOwogCiAgICAgLy8gQ2xlYW4gYW55IGVudHJp ZXMgZnJvbSB0aGUgRG93bmxvYWQgTWFuYWdlciBkYXRhYmFzZQogICAgIHRoaXMuY2xlYW5VcCgp OwogICB9LAogCiAgIC8qKgogICAgKiBDbG9zZSB0aGUgZG93bmxvYWQgbWFuYWdlcgo=