100172 - need scriptable string stream implementation (must support nsIInputStream)

Status: RESOLVED FIXED

(Core :: XPCOM, defect, P2)

Description

[Darin Fisher]

need scriptable string stream implementation (must support nsIInputStream)
this is needed to support nsIUploadChannel usage via JS.

Comment 1

[Darin Fisher]

i filed a similar bug a while back, but can't seem to find it now.  i think this
is urgently needed... as in by mozilla0.9.5.

Comment 2

[Darin Fisher]

-> me

Comment 3

[Darin Fisher]

Attachment: nsIStringInputStream.idl

Comment 4

[Darin Fisher]

dougt: can you comment on attachment 50334 [details]? thanks!

Comment 5

[Kathleen :Brade]

Does this interface handle double-byte strings (like Japanese)?
I expected to see wstring.

Where do I get the nsIInputStream from?

Comment 6

[Doug Turner (:dougt)]

looks fine:

use the /** **/ style comments instead of the c++ // comment. 
(unless you know more about doxygen that I do, which is probably the case).

Also, I am not sure what the mantra is regarding CONTRACTID, CLASSNAME, and CID
declarations in an IDL.  Rick, Vidur?

Comment 7

[Darin Fisher]

brade: you can only upload bytes to a necko channel... you will have to make
sure that the data is properly encoded before uploading.

dougt:

1- will change to /** **/ comments just to be consistent
2- followed nsILocalFile for an example of how CID, CONTRACTID, and CLASSNAME
are declared in XPCOM

Comment 8

[Doug Turner (:dougt)]

This is probably something that we should freeze soon as many scripters will
begin using it.  

Comment 9

[rpotts (gone)]

take a look at the bottom of
http://www.mozilla.org/projects/embedding/EmbedInterfaceFreeze.html for
information about what is needed to freeze a component...

-- rick

Comment 10

[Darin Fisher]

i'm planning to just implement this interface using the impl's in
nsIStringStream.cpp for now... the nsIStringStream.h C++ api will not be touched.
we will also probably want a nsIStringOutputStream and perhaps a
nsIStringIOStream.  but, perhaps those interfaces are less urgently needed.

Comment 11

[Darin Fisher]

*** Bug 100171 has been marked as a duplicate of this bug. ***

Comment 12

[Darin Fisher]

-> 0.9.6

Comment 13

[Darin Fisher]

looks like i'm not going to have time for this now -> 0.9.7

Comment 14

[Darin Fisher]

Attachment: v1.0 patch

this patch takes a slightly different approach.. see nsIStringStream.idl

Comment 15

[Darin Fisher]

Comment on attachment 58507 [details] [diff] [review]
v1.0 patch

actually, this patch still needs work.. the nsIStringInputStream needs a
factory.

Comment 16

[Darin Fisher]

Attachment: v1.1 final patch

moving some files around:

nsIStringStream.h   -> nsIStringStream.idl
nsIStringStream.cpp -> nsStringStream.cpp

and created:

nsStringStream.h

Comment 17

[Darin Fisher]

Attachment: v1.2 added contributors per "cvs log" to renamed files

Comment 18

[Darin Fisher]

Comment on attachment 58784 [details] [diff] [review]
v1.2 added contributors per "cvs log" to renamed files

got an r=dougt via AIM

Comment 19

[rpotts (gone)]

Comment on attachment 58784 [details] [diff] [review]
v1.2 added contributors per "cvs log" to renamed files

sr=[e-mail]

Comment 20

[Darin Fisher]

fixed-on-trunk