Closed
Bug 1007501
Opened 10 years ago
Closed 7 years ago
Initial (v0) Deploy of Slaveloan tool
Categories
(Release Engineering :: General, defect)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: Callek, Assigned: Callek)
References
Details
(Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1949] )
Attachments
(1 file)
10.38 KB,
patch
|
dustin
:
feedback+
|
Details | Diff | Splinter Review |
To get slaveloan tool able to be iterated on by many humans, we need an initial skeleton deployed to do so. This bug will handle that skeleton
Assignee | ||
Comment 1•10 years ago
|
||
Feedback welcome
Comment 2•10 years ago
|
||
Comment on attachment 8419184 [details] [diff] [review] [relengapi] WIP 1 "Human" and "human" should be plural in the model. Also, 'import *' is frowned upon by tools like pyflakes (and, I think, pep8) since it introduces arbitrary symbols into the namespace without any syntactic indication of *which* symbols. Please change the * in __init__.py to list the model classes explicitly. The POST to /admin/ should be a REST-style POST, rather than a browser form submission. The differences are minor, but involve sending a JSON request in the POST body, rather than form-encoded, and flagging it with @apimethod. You'll need to do a little jQuery work on the browser side to make that happen. You can look at the tokenauth blueprint for an example of that. Finally, please delete the dangling 'slaveloan/src' symlink
Attachment #8419184 -
Flags: feedback+
Updated•10 years ago
|
Blocks: byebyebuildduty
Updated•10 years ago
|
No longer blocks: byebyebuildduty
Updated•10 years ago
|
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1949]
Updated•7 years ago
|
Component: Tools → General
Assignee | ||
Comment 3•7 years ago
|
||
What was worked on in this bug is now dead/unmaintained code, I'm calling this wontfix.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•