Closed
Bug 100802
Opened 23 years ago
Closed 23 years ago
toolbar flashes when I delete a mail
Categories
(SeaMonkey :: MailNews: Message Display, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: sspitzer, Assigned: Bienvenu)
Details
(Keywords: perf)
Attachments
(1 file)
724 bytes,
patch
|
cavin
:
review+
sspitzer
:
superreview+
|
Details | Diff | Splinter Review |
toolbar flashes when I delete a mail I think it's because we are updating commands. I think bienvenu worked on this once. I think he saw that when going from 1 selected item to 0 to 1 again would cause us to update commands. in theory, we could avoid that work. bienvenu, did you log a bug on this already? maybe you found it when fixing the problem where the delete toolbar button was disabled?
Assignee | ||
Comment 1•23 years ago
|
||
sure, it's just the selection goes from 1 to 0 back to 1 again, so we update the commands for each of those transitions. We may already know in the view that we're doing a delete, in which case we could perhaps disable the command updating. I'll look at it in a minute.
Comment 2•23 years ago
|
||
Do you think this would have any impact on delete message perf and if so how much do you think it would be?
Keywords: perf
Assignee | ||
Comment 3•23 years ago
|
||
yes, it has an impact, but I don't know how much the impact is. It's a fixed cost and it's worth investigating. Sorry I haven't got around to this - I forgot because it wasn't assigned to me.
Assignee: sspitzer → bienvenu
Assignee | ||
Comment 4•23 years ago
|
||
Assignee | ||
Comment 5•23 years ago
|
||
Can I get some reviews? This fix makes it so we don't update the commands while the delete is going on, so we don't update commands when there's nothing selected, and then again when we select a message. So we still do an extra update, but it doesn't cause any repaints, so it should be faster.
Status: NEW → ASSIGNED
Reporter | ||
Comment 6•23 years ago
|
||
Comment on attachment 55944 [details] [diff] [review] proposed fix sr=sspitzer
Attachment #55944 -
Flags: superreview+
Comment 7•23 years ago
|
||
Comment on attachment 55944 [details] [diff] [review] proposed fix r=cavin.
Attachment #55944 -
Flags: review+
Assignee | ||
Comment 8•23 years ago
|
||
fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Comment 9•23 years ago
|
||
I deleted small to large single messages and there was not tool bar flashing while deleting a mail message. I deleted message from the toolbar. Verified: 2001-11-15-05 win98, linux, mac os x
Status: RESOLVED → VERIFIED
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•