100895 - Extraneous include's introduce unwanted dependencies

Status: VERIFIED FIXED

(Core :: DOM: HTML Parser, defect, P3)

Description

[Jon Smirl]

Unnecessary includes in htmlparser files...
#include "nsIXMLContentSink.h"
#include "nsITextContent.h"

cause unnecessary module dependencies
nkcache
widget
raptor
content

Removing includes removes dependecies

Comment 1

[Jon Smirl]

Attachment: remove include and fix dependencies

Comment 2

[Alec Flett]

Comment on attachment 50208 [details] [diff] [review]
remove include and fix dependencies

nice! sr=alecf

Comment 3

[harishd]

Comment on attachment 50208 [details] [diff] [review]
remove include and fix dependencies

r=harishd

Comment 4

[Håkan Waara]

Who wants to checkin this puppy?

Comment 5

[harishd]

--> 0.9.6

Comment 6

[Alec Flett]

just checked in the patch.. reassigning to jonsmirl to be marked fixed. Thanks jon!

Comment 7

[Alec Flett]

marking fixed.

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

To fix bustage I had to add the nkcache back into the REQUIRES line. 
nsParser.cpp includes nsICacheEntryDescriptor.h.

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

... and the reason you didn't catch that is that you compiled on Windows, where
cache is not its own module (bug 103988).

Comment 10

[Jon Smirl]

I just pulled and built and had trouble with this.

content is out of the makefile like it should be but this is still in:

===================================================================
RCS file: /cvsroot/mozilla/htmlparser/src/nsWellFormedDTD.cpp,v
retrieving revision 3.88
diff -u -r3.88 nsWellFormedDTD.cpp
--- mozilla/htmlparser/src/nsWellFormedDTD.cpp	2001/09/08 18:37:19	3.88
+++ mozilla/htmlparser/src/nsWellFormedDTD.cpp	2001/09/21 04:37:08
@@ -35,7 +35,6 @@
 #include "nsDTDUtils.h"
 #include "nsIContentSink.h"
 #include "nsIHTMLContentSink.h"
-#include "nsIXMLContentSink.h"
 #include "nsHTMLTokenizer.h"
 #include "nsExpatTokenizer.h"
 
which makes me need content. XMLContentSink is not used (at least on windows it 
isn't). The makefile is right and XMLContentSink should be removed.

Comment 11

[Bradley Baetz (:bbaetz)]

Jon: that file's on the svg branch now, which is why it didn't show up. And I'd
merged 5 minutes before... Fixed now.

Comment 12

[Alec Flett]

thanks to dbaron for catching that. I'm making nkcache a real module on windows
so I don't bust in the future :)

Comment 13

[Moied]

verified fix checked in cvs (rev 3.90)