1010128 - [Flatfish] Set GAIA_DEVICE_TYPE for tablet distribution

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Danny Liang [:dliang]]

Due to Gaia will be remove the distribution_tablet folder, so we need to set GAIA_DEVICE_TYPE for correct distribution.

Comment 1

[Danny Liang [:dliang]]

Attachment: pull request for bug 1010128.html

Comment 2

[Kai-Zhen Li [:seinlin][:kli]]

Comment on attachment 8422334 [details]
pull request for bug 1010128.html

Marco, Now GAIA can support build for different distribution. We need to add "tablet" distribution for flatfish. Could you help to review this patch? Thanks!

Comment 3

[Marco Chen [:mchen]]

Comment on attachment 8422334 [details]
pull request for bug 1010128.html

Hi,

Is GAIA_DEVICE_TYPE a env variable or just a variable in make process?

I think it is for make process, could you just use "GAIA_DEVICE_TYPE := tablet"?
(ex: https://github.com/mozilla-b2g/device-helix/blob/master/full_helix.mk#L35)

Comment 4

[Danny Liang [:dliang]]

(In reply to Marco Chen [:mchen] from comment #3)
> Comment on attachment 8422334 [details]
> pull request for bug 1010128.html
> 
> Hi,
> 
> Is GAIA_DEVICE_TYPE a env variable or just a variable in make process?
> 
> I think it is for make process, could you just use "GAIA_DEVICE_TYPE :=
> tablet"?
> (ex:
> https://github.com/mozilla-b2g/device-helix/blob/master/full_helix.mk#L35)

It's just for make process, but GAIA_DEVICE_TYPE is checked in Makefile, not .mk file, the flag in full_flatfish.mk cannot be passed to gaia by "GAIA_DEVICE_TYPE := tablet".

Hi Gary,
Could you add some check in Android.mk to receive this gaia flag? The example as below:

./Android.mk:33:ifneq (,$(GAIA_DEV_PIXELS_PER_PX))
./Android.mk:34:GAIA_MAKE_FLAGS += GAIA_DEV_PIXELS_PER_PX=$(GAIA_DEV_PIXELS_PER_PX)

And then we can use GAIA_DEVICE_TYPE := tablet to follow the code style in .mk file.
Thanks,

Comment 5

[Kai-Zhen Li [:seinlin][:kli]]

Danny, I think you are right. As I know gaia Makefile can't use compile flag from aosp build system, and need to export as an env variable. That's why I had feedback+ to your patch.

Comment 6

[Marco Chen [:mchen]]

Hi Danny,

Yes, add new make flags from AOSP build system into GAIA_MAKE_FLAGS should be a generic way for passing into Gaia build system. And we already had an example from GAIA_DEV_PIXELS_PER_PX.

Comment 7

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

(In reply to Danny Liang [:dliang] from comment #4)
> (In reply to Marco Chen [:mchen] from comment #3)
> > Comment on attachment 8422334 [details]
> > pull request for bug 1010128.html
> > 
> > Hi,
> > 
> > Is GAIA_DEVICE_TYPE a env variable or just a variable in make process?
> > 
> > I think it is for make process, could you just use "GAIA_DEVICE_TYPE :=
> > tablet"?
> > (ex:
> > https://github.com/mozilla-b2g/device-helix/blob/master/full_helix.mk#L35)
> 
> It's just for make process, but GAIA_DEVICE_TYPE is checked in Makefile, not
> .mk file, the flag in full_flatfish.mk cannot be passed to gaia by
> "GAIA_DEVICE_TYPE := tablet".
> 
> Hi Gary,
> Could you add some check in Android.mk to receive this gaia flag? The
> example as below:
> 
> ./Android.mk:33:ifneq (,$(GAIA_DEV_PIXELS_PER_PX))
> ./Android.mk:34:GAIA_MAKE_FLAGS +=
> GAIA_DEV_PIXELS_PER_PX=$(GAIA_DEV_PIXELS_PER_PX)
> 
> And then we can use GAIA_DEVICE_TYPE := tablet to follow the code style in
> .mk file.
> Thanks,

Hi Danny,
   OK!!!
   I just send a patch and ask Marco and Yuren to review my patch.
   Please wait for landing that patch.
   Thanks.

Comment 8

[Danny Liang [:dliang]]

Comment on attachment 8422334 [details]
pull request for bug 1010128.html

I have modified the PR and please help to review it.

Comment 9

[Marco Chen [:mchen]]

Comment on attachment 8422334 [details]
pull request for bug 1010128.html

Thanks for looking into tablet project.

Comment 10

[Carsten Book [:Tomcat]]

master: https://github.com/mozilla-b2g/device-flatfish/commit/9cc3935a9d7b56e089021f2cd65ba213fa1ea904