101429 - DOM Inspector bad argument to function in inLayoutUtils::GetSubDocumentFor()

Status: RESOLVED FIXED

(SeaMonkey :: General, defect, P4)

Description

[Heikki Toivonen (remove -bugzilla when emailing directly)]

nsIPresShell::GetSubShellFor() needs an argument of type nsISupports for the
second parameter. You are using nsIPresShell. This asserts, and can cause crash
conditions etc. I'll attach a fix.

Comment 1

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Attachment: Proposed fix

Comment 2

[Joe Hewitt (gone)]

[s]r=hewitt - Thanks heikki!

Comment 3

[Joe Hewitt (gone)]

over to Heikki since he has the fix

Comment 4

[harishd]

Comment on attachment 50594 [details] [diff] [review]
Proposed fix

>+      if (!docShell) return nsnull;

Separate lines please

>+      if (!contentViewer) return nsnull;

Separate lines please.

Comment 5

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Checked in with the change harishd requested.

Comment 6

[Hixie (not reading bugmail)]

Obsolete DOM Viewer bugs -> Browser-General; DOM Viewer component is going away.