101609 - JSS OSF fails

Status: RESOLVED FIXED

(JSS Graveyard :: Library, enhancement)

Description

[Sonja Mirtitsch]

I'm filing unauthorized bugs again, hope I don't make a new enemy...
I wanted to file this against the JSS build, but that was not a choice here.

When checking out coreconf with the static tag "NSS_3_3_RTM" the builds pass,
when using the current coreconf, which I need for the NT build to pass it fails
with and ld error:
gmake[1]: Entering directory
`/tmp_mnt/share/builds/mccrel/jss/jsstip/builds/20010925.1/booboo_Solaris8/mozilla/security/jss/lib'
grep -v ';+' jss.def | grep -v ';-' | \
 sed -e 's; DATA ;;' -e 's,;;,,' -e 's,;.*,,' -e 's,^,-exported_symbol ,' >
OSF1V4.0D_DBG.OBJ/jssmap.osf
rm -f OSF1V4.0D_DBG.OBJ/libjss3.so
ld -shared -expect_unresolved "*" -soname libjss3.so -B symbolic -hidden -input
OSF1V4.0D_DBG.OBJ/jssmap.osf -o OSF1V4.0D_DBG.OBJ/libjss3.so 
../org/mozilla/jss/crypto/OSF1V4.0D_DBG.OBJ/Algorithm.o
../org/mozilla/jss/crypto/OSF1V4.0D_DBG.OBJ/PQGParams.o
../org/mozilla/jss/manage/OSF1V4.0D_DBG.OBJ/CryptoManager.o
../org/mozilla/jss/manage/OSF1V4.0D_DBG.OBJ/PK11Finder.o
../org/mozilla/jss/pkcs11/OSF1V4.0D_DBG.OBJ/PK11Cert.o
../org/mozilla/jss/pkcs11/OSF1V4.0D_DBG.OBJ/PK11Cipher.o
../org/mozilla/jss/pkcs11/OSF1V4.0D_DBG.OBJ/PK11KeyGenerator.o
../org/mozilla/jss/pkcs11/OSF1V4.0D_DBG.OBJ/PK11KeyPairGenerator.o
../org/mozilla/jss/pkcs11/OSF1V4.0D_DBG.OBJ/PK11KeyWrapper.o
../org/mozilla/jss/pkcs11/OSF1V4.0D_DBG.OBJ/PK11MessageDigest.o
../org/mozilla/jss/pkcs11/OSF1V4.0D_DBG.OBJ/PK11Module.o
../org/mozilla/jss/pkcs11/OSF1V4.0D_DBG.OBJ/PK11PrivKey.o
../org/mozilla/jss/pkcs11/OSF1V4.0D_DBG.OBJ/PK11PubKey.o
../org/mozilla/jss/pkcs11/OSF1V4.0D_DBG.OBJ/PK11Signature.o
../org/mozilla/jss/pkcs11/OSF1V4.0D_DBG.OBJ/PK11SecureRandom.o
../org/mozilla/jss/pkcs11/OSF1V4.0D_DBG.OBJ/PK11Store.o
../org/mozilla/jss/pkcs11/OSF1V4.0D_DBG.OBJ/PK11SymKey.o
../org/mozilla/jss/pkcs11/OSF1V4.0D_DBG.OBJ/PK11Token.o
../org/mozilla/jss/ssl/OSF1V4.0D_DBG.OBJ/SSLSocket.o
../org/mozilla/jss/ssl/OSF1V4.0D_DBG.OBJ/callbacks.o
../org/mozilla/jss/ssl/OSF1V4.0D_DBG.OBJ/SSLServerSocket.o
../org/mozilla/jss/ssl/OSF1V4.0D_DBG.OBJ/common.o
../org/mozilla/jss/ssl/OSF1V4.0D_DBG.OBJ/javasock.o
../org/mozilla/jss/util/OSF1V4.0D_DBG.OBJ/jssutil.o
../org/mozilla/jss/util/OSF1V4.0D_DBG.OBJ/jssver.o
../org/mozilla/jss/util/OSF1V4.0D_DBG.OBJ/errstrings.o -taso  
-L../../../dist/OSF1V4.0D_DBG.OBJ/lib -lnss3 -lsmime3 -lssl3 -lplc4 -lplds4
-lnspr4 -L/share/builds/components/jdk/1.2.2/OSF1/jre/lib/alpha/native_threads
-lhpi -L/share/builds/components/jdk/1.2.2/OSF1/jre/lib/alpha/classic -ljvm
-L/share/builds/components/jdk/1.2.2/OSF1/jre/lib/alpha -ljava 
-L/share/builds/components/jdk/1.2.2/OSF1/jre/lib/alpha.no 
ld:
Badly formed hex number: symbolic
ld: Usage: ld [options] file [...]
gmake[1]: *** [OSF1V4.0D_DBG.OBJ/libjss3.so] Error 1
gmake[1]: Leaving directory
`/tmp_mnt/share/builds/mccrel/jss/jsstip/builds/20010925.1/booboo_Solaris8/mozilla/security/jss/lib'
gmake: *** [libs] Error 2
Elapsed Time = 00:01:37
Tue 25 Sep 2001 12:07:29

Comment 1

[Sonja Mirtitsch]

Attachment: JSS 3.1 DBG built with new coreconf (failed)

Comment 2

[Sonja Mirtitsch]

Attachment: JSS 3.1 DBG built with NSS_3_3_RTM coreconf (passed)

Comment 3

[Jamie Nicolson]

Sonja,

Can you please do a "which ld"?

The ld man page does indicate that the -B argument is supposed to take a number,
not the word "symbolic". But it works for me. Possibly it depends which version
and supplier of ld we are using.

Comment 4

[Sonja Mirtitsch]

in a regular svbld login shell which ld gives 
/bin/ld
version 3.11
I am not completely convinced that that is the ld that is being used in the
build, since I am not so familiar with the buildsystem - maybe the linker is
being changed - you could ask Anthony. 
With the coreconf that is tagged NSS_3_3_RTM it builds fine.

Comment 5

[Jamie Nicolson]

I removed the "-B symbolic" flag in mozilla/security/jss/config/config.mk on the
JSS_3_1_BRANCH. This should fix this specific problem.

I created a bug to deal with the general problem:
http://bugzilla.mozilla.org/show_bug.cgi?id=102922 (get rid of -B symbolic
linker option).

Comment 6

[Sonja Mirtitsch]

works now on the 3.1 branch, could you please remember to check the fix in at
the tip as well?.
Thanks

Comment 7

[Sonja Mirtitsch]

Please fix on the tip as well. Thanks

Comment 8

[Jamie Nicolson]

Fixed on the trunk.

/cvsroot/mozilla/security/jss/config/config.mk,v  <--  config.mk
new revision: 1.5; previous revision: 1.4