Closed Bug 1016678 Opened 10 years ago Closed 10 years ago

Add textured compositor benchmark

Categories

(Core :: Graphics: Layers, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla32

People

(Reporter: BenWa, Assigned: BenWa)

References

Details

Attachments

(1 file, 2 obsolete files)

Attached patch patch (obsolete) — Splinter Review
+++ This bug was initially created as a clone of Bug #1014042 +++
Attachment #8429622 - Flags: review?(jmuizelaar)
Attached patch gralloc tests (obsolete) — Splinter Review
Assignee: nobody → bgirard
Status: NEW → ASSIGNED
Attachment #8430848 - Flags: review?(jmuizelaar)
Comment on attachment 8429622 [details] [diff] [review]
patch

Review of attachment 8429622 [details] [diff] [review]:
-----------------------------------------------------------------

I think this would be better organized as helper functions instead of using inheritance. That will make what's happening more explicit and allow better code sharing.
Attachment #8429622 - Flags: review?(jmuizelaar) → review-
Comment on attachment 8430848 [details] [diff] [review]
gralloc tests

Review of attachment 8430848 [details] [diff] [review]:
-----------------------------------------------------------------

Same comment as the other patch
Attachment #8430848 - Flags: review?(jmuizelaar) → review-
Attached file patch v5 r=jrmuizel
I accidentally posted this patch in bug 1014042. It's been reviewed there.
Attachment #8429622 - Attachment is obsolete: true
Attachment #8430848 - Attachment is obsolete: true
Attachment #8435929 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/303d1ac47d5c
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: