101672 - generate-id is overly complicated

Status: VERIFIED FIXED

(Core :: XSLT, defect)

Description

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

our current generate-id() function is unneccesarily complicated. The fastest 
and simplest way to generate the id should be to just convert the node-pointer 
to a string and prepend some string to make sure the id is a valid xml-name.

This is currently blocking orderinfo moving of orderInfo since it was easier to 
remove the use of orderInfo there then to fix how it was used...

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: this should do it

Comment 2

[Axel Hecht]

+        ExprResult* exprResult = param->evaluate(aContext, aCs);
+        if (!exprResult)
+            return new StringResult();

This is prolly out of mem, so returning a new (even if empty) stringresult
isn't safer and more expressive than just returning 0. IMHO.

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: this should do it, ver 2

Comment 4

[Peter Van der Beken [:peterv]]

Comment on attachment 50872 [details] [diff] [review]
this should do it, ver 2

30 is overkill, use 20. With that, r=peterv.

Comment 5

[Axel Hecht]

Comment on attachment 50872 [details] [diff] [review]
this should do it, ver 2

with "id%08p" -> "id-0x%08p" (16 as well)
r=[e-mail]

Comment 6

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

we agreed on irc to go with "id0x%08p" and size 22

Comment 7

[Johnny Stenback (:jst)]

Comment on attachment 50872 [details] [diff] [review]
this should do it, ver 2

sr=jst

Comment 8

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

checked in. Thanks for reviews and superreviews

Comment 9

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

verified