Closed
Bug 1016916
Opened 10 years ago
Closed 10 years ago
[mozlog.structured] formatter modules have non-working __main__ sections
Categories
(Testing :: Mozbase, defect)
Testing
Mozbase
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla33
People
(Reporter: ted, Assigned: jgraham)
Details
Attachments
(1 file)
|
6.70 KB,
patch
|
wlach
:
review+
|
Details | Diff | Splinter Review |
All the structured logging formatter modules have a __main__ section that references a nonexistent base.format_file method: http://hg.mozilla.org/mozilla-central/annotate/cbe4f69c2e9c/testing/mozbase/mozlog/mozlog/structured/formatters/html/html.py#l163 We should either fix that or remove it as it's confusing.
|
Assignee | |
Comment 1•10 years ago
|
||
This replaces the __main__ sections in the formatters
Attachment #8430153 -
Flags: review?(wlachance)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8430153 [details] [diff] [review] Add a 'structlog format' command for formatting logfiles. Looks reasonable.
Attachment #8430153 -
Flags: review?(wlachance) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/7a5ae7eec2db
|
||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/7a5ae7eec2db
Assignee: nobody → james
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in
before you can comment on or make changes to this bug.
Description
•