Closed
Bug 1016928
Opened 10 years ago
Closed 10 years ago
[Home2] Create build script for vertical homescreen
Categories
(Firefox OS Graveyard :: Gaia::Homescreen, defect)
Tracking
(b2g-v2.0 fixed)
RESOLVED
FIXED
2.0 S3 (6june)
Tracking | Status | |
---|---|---|
b2g-v2.0 | --- | fixed |
People
(Reporter: albert, Assigned: albert)
References
Details
(Whiteboard: [systemsfe])
Attachments
(1 file)
Create build.js to generate single variant config during build process according to requirements specified in bug 1006172
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → acperez
Assignee | ||
Comment 1•10 years ago
|
||
Updated•10 years ago
|
Whiteboard: [systemsfe]
Assignee | ||
Comment 2•10 years ago
|
||
Comment on attachment 8430004 [details]
Patch
Added script to generate single variant for vertical homescreen.
Attachment #8430004 -
Flags: review?(yurenju.mozilla)
Comment 3•10 years ago
|
||
Comment on attachment 8430004 [details]
Patch
r=yurenju if change naming rule from snake case to camel case (like search_page_enabled to searchPageEnabled)
Attachment #8430004 -
Flags: review?(yurenju.mozilla) → review+
Comment 4•10 years ago
|
||
Vertical homescreen has been moved into apps/verticalhome. See: https://bugzilla.mozilla.org/show_bug.cgi?id=1009111
Depends on: 1009111
Assignee | ||
Comment 5•10 years ago
|
||
(In reply to Yuren [:yurenju] from comment #3) > Comment on attachment 8430004 [details] > Patch > > r=yurenju if change naming rule from snake case to camel case (like > search_page_enabled to searchPageEnabled) The major part of snake case vars come frome old homescreen, if I change them then the init.json will change completely, is that what you want?
Flags: needinfo?(yurenju.mozilla)
Comment 6•10 years ago
|
||
no, I meant variables like search_page_debug on line 255[1] which is used for "debug" field of init.json, and tap_effect_delay on line 208[2] which is used for "tap_effect_delay" field, we only change variables in javascript but not change anything in init.json. but this is a minor issue for this pr, I'm fine if you file another follow-up bug for this enhancement and land it first. [1] https://github.com/acperez/gaia/blob/bug-1016928/dev_apps/home2/build/build.js#L255 [2] https://github.com/acperez/gaia/blob/bug-1016928/dev_apps/home2/build/build.js#L208
Flags: needinfo?(yurenju.mozilla)
Assignee | ||
Comment 7•10 years ago
|
||
Comment on attachment 8430004 [details]
Patch
Moved files to apps/verticalhome and modified vars from snake case to camel case
Attachment #8430004 -
Flags: review+ → review?(yurenju.mozilla)
Updated•10 years ago
|
Attachment #8430004 -
Flags: review?(yurenju.mozilla) → review+
Assignee | ||
Comment 8•10 years ago
|
||
Master: https://github.com/mozilla-b2g/gaia/commit/920adfd797457647529ecabbb9f0543b8e8d3d2f
Assignee | ||
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
Target Milestone: --- → 2.0 S3 (6june)
Comment 9•10 years ago
|
||
Mass modify - set status-b2g-v2.0 fixed for fixed bugs under vertical homescreen dependency tree.
status-b2g-v2.0:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•