1017183 - xpcshell/mail/steel/test/test_linux_platformChecks.js fails on Linux when gconf is disabled

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[:aceman]

I have ac_add_options --disable-gconf in .mozconfig, then I get this failure permanently:

TEST-INFO | /var/SSD/TB-hg/tbird-bin/mozilla/_tests/xpcshell/mail/steel/test/test_linux_platformChecks.js | running test ...
TEST-UNEXPECTED-FAIL | /var/SSD/TB-hg/tbird-bin/mozilla/_tests/xpcshell/mail/steel/test/test_linux_platformChecks.js | test failed (with xpcshell return code: 0), see following log:
>>>>>>>
TEST-INFO | (xpcshell/head.js) | test MAIN run_test pending (1)
TEST-UNEXPECTED-FAIL | /var/SSD/TB-hg/tbird-bin/mozilla/_tests/xpcshell/mail/steel/test/test_linux_platformChecks.js | false == true - See following stack:
JS frame :: /var/SSD/TB-hg/tbird-bin/mozilla/_tests/xpcshell/mail/steel/test/test_linux_platformChecks.js :: run_test :: line 11
JS frame :: /var/SSD/TB-hg/mozilla/testing/xpcshell/head.js :: _execute_test :: line 387
JS frame :: -e :: <TOP_LEVEL> :: line 1
native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0
TEST-INFO | (xpcshell/head.js) | exiting test

It is because steelApplication determines to be running under linux by checking if "gconf" exists in Components.classes. That does not seem right.

Comment 1

[:aceman]

Attachment: patch

This fixes it for me. We can't use Services.appinfo.OS as that returns "XPCShell" instead or real OS when running the test.

Comment 2

[Magnus Melin [:mkmelin]]

Or || @mozilla.org/gio-service;1 ?

Comment 3

[:aceman]

There doesn't seem to be such a thing.
And guess what, gio can be disabled too :)

Comment 4

[Magnus Melin [:mkmelin]]

Huh? "@mozilla.org/gio-service;1" in Components.classes is true for me

I was under the assumption you have to use one of them. "Have to" if you have the full build...

Comment 5

[Magnus Melin [:mkmelin]]

Remember solaris, openbsd and other platforms that want to be (in this context) counted as linux.

Comment 6

[:aceman]

Then they get caught by the gconf test ;) If they disable gconf then they are out of luck the same as Linux was before the patch. So they need to add their own test here.
Anyway, as you can see I add the gconf test in. So I expand it and count more systems as Linux (!gconf || Linux). I do not restrict it.

Comment 7

[Magnus Melin [:mkmelin]]

Yes, it's an improvement. I just suggested testing for gio-service too would be safer.

Comment 8

[:aceman]

Yes, if you meant it as an addition I can do it too. I just understood it as a replacement of gconf with gio (which wouldn't help me as I have that disabled too).

Comment 9

[:aceman]

Attachment: patch v2

Comment 10

[:aceman]

Thanks.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/c01fd1da06d5