1017441 - [Gaia][Contacts] Contact screen scroll beyond 'A ~ Z-#' shows blank preview screen.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[ashayb2g]

Steps to reproduce:

Scroll in quick scroll(A~Z) from bottom to top or top to bottom 


Actual results:
First the letter disappears and then it shows a blank preview screen.


Expected results:
It should not shows a blank preview screen.

Comment 1

[ashayb2g]

Hi Ayman,

Can you please provide your input on this issue, weather it should be corrected or the current implementation is fine ?

Comment 2

[Francisco Jordano [:arcturus] [:francisco]]

Can we have a screenshot or video with the commented problem?

Thanks!

Comment 3

[ashayb2g]

Attachment: Scroll_Issue .mp4

Hi Francisco,

PFA video shows the blank preview.
Please check and let me know whether this behavior is fine or we need to make change.

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Thanks,

QA wanted to check in which versions is this happening.

IMHO, non blocking

Comment 5

[ashayb2g]

This happens even in master.

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

Attachment: Pointer to pr 20028

Comment 7

[Jason Smith [:jsmith]]

If this isn't a blocking issue, then we really don't need to do a branch comparison analysis here.

Comment 8

[Jose Manuel Cantera]

Comment on attachment 8434329 [details] [review]
Pointer to pr 20028

looks good, works ok, although we need some improvements as per the comments on GH

thanks!

Comment 9

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8434329 [details] [review]
Pointer to pr 20028

Done, ready for 2nd review :)

Comment 10

[Jose Manuel Cantera]

Comment on attachment 8434329 [details] [review]
Pointer to pr 20028

thanks Francisco, good job. I left a tiny comment on GH for your consideration

best

Comment 11

[Francisco Jordano [:arcturus] [:francisco]]

Finally added your suggestion since totally makes sense.

Didn't ask for review since is a minimun change and will carry over the r+ and land once travis is green.

Thanks a lot!

Comment 12

[Francisco Jordano [:arcturus] [:francisco]]

Landed:

https://github.com/arcturus/gaia/commit/6bb56c1f1f86217196f3b5e3a3d7e25f1e4ec5a7