Closed
Bug 1017512
Opened 10 years ago
Closed 10 years ago
Selected toolbox tab doesn't have a background on :active state
Categories
(DevTools :: General, defect)
DevTools
General
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 32
People
(Reporter: ntim, Assigned: bgrins)
References
Details
Attachments
(1 file)
|
1.15 KB,
patch
|
vporof
:
review+
|
Details | Diff | Splinter Review |
I'm suspecting bug 991810 to have caused this.
|
Assignee | |
Comment 1•10 years ago
|
||
I see this on osx as well
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
OS: Windows 8.1 → All
Hardware: x86_64 → All
|
|
Assignee | |
Comment 2•10 years ago
|
||
I thought I was able to remove some complexity in Bug 991810 by removing the #toolbox-tabs piece out of this selector: .theme-light #toolbox-tabs .devtools-tab[selected] But no, that was guaranteeing that even on an active state the background color would be the same. So if you hold a mouse down on the already selected tab, it currently becomes grey, but is fixed with this patch.
Attachment #8430757 -
Flags: review?(vporof)
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8430757 [details] [diff] [review] selected-tool-active.patch Review of attachment 8430757 [details] [diff] [review]: ----------------------------------------------------------------- OK
Attachment #8430757 -
Flags: review?(vporof) → review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/61bda59ea4b6
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/61bda59ea4b6
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 32
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•