1017596 - Send messages suite_start and suite_end in moztest.adapters.unit

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[Andreas Tolfsen ❲:ato❳]

moztest.adapters.unit.StructuredTestResult doesn't correctly implement the structured logging protocol by leaving out the suite_start and suite_end messages.

Specifically it's missing the suite_start and suite_end messages.  The startTestRun and stopTestRun unittest methods are currently no-op's.

It would also be useful is StructuredTestRunner took a test_list property that is [] by default but can be set to a list of tests which could be included as an extra field in the suite_start message.

Comment 1

[Andreas Tolfsen ❲:ato❳]

Attachment: 0001-Bug-1017596-Add-suite_start-and-suite_end-messages-t.patch

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Either this or bug 1017675 caused a spike in Marionette test failures. Backed out.
https://hg.mozilla.org/integration/mozilla-inbound/rev/c18cab47948a

https://tbpl.mozilla.org/php/getParsedLog.php?id=40655050&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=40658861&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=40660047&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=40656229&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=40658656&tree=Mozilla-Inbound

Comment 3

[James Graham [:jgraham]]

That seems very surprising since afaict this code isn't used by the marionette tests.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/246b25b05b59

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/246b25b05b59